Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DisplayNameValidation): Integrate duplicate display name in joined communities #13942

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(DisplayNameValidation): Integrate duplicate display name in joined communities #13942

merged 1 commit into from
Mar 14, 2024

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Mar 12, 2024

What does the PR do

Closing: #13434

Validate the display name against the joined community members.

Affected areas

Profile identity - Display name validation

@alexjba
Copy link
Contributor Author

alexjba commented Mar 12, 2024 •
edited

@MishkaRogachev Looks like something's wrong with the display name validation. I've integrated the display name validation in the UI, but status-go is crashing

DBG 2024-03-12 16:54:49.592+02:00 NewBE_callPrivateRPC                       topics="rpc" tid=35611638 file=core.nim:27 rpc_method=wakuext_isDisplayNameDupeOfCommunityMember
Process 99363 stopped
* thread #75, stop reason = EXC_BAD_ACCESS (code=1, address=0x80)
    frame #0: 0x000000010a34f004 libstatus.dylib`github.com/status-im/status-go/protocol.(*Messenger).IsDisplayNameDupeOfCommunityMember + 452
libstatus.dylib`github.com/status-im/status-go/protocol.(*Messenger).IsDisplayNameDupeOfCommunityMember:
->  0x10a34f004 <+452>: ldr    x1, [x0, #0x80]
    0x10a34f008 <+456>: ldr    x0, [x0, #0x78]
    0x10a34f00c <+460>: ldr    x3, [sp, #0x108]
    0x10a34f010 <+464>: cmp    x3, x1
Target 0: (nim_status_client) stopped.
(lldb) bt
* thread #75, stop reason = EXC_BAD_ACCESS (code=1, address=0x80)
  * frame #0: 0x000000010a34f004 libstatus.dylib`github.com/status-im/status-go/protocol.(*Messenger).IsDisplayNameDupeOfCommunityMember + 452
    frame #1: 0x000000010a4ab3e4 libstatus.dylib`github.com/status-im/status-go/services/wakuv2ext.(*PublicAPI).IsDisplayNameDupeOfCommunityMember + 52
    frame #2: 0x0000000108c09458 libstatus.dylib`runtime.call32.abi0 + 120
    frame #3: 0x0000000108c09458 libstatus.dylib`runtime.call32.abi0 + 120
    frame #4: 0x0000000108c09458 libstatus.dylib`runtime.call32.abi0 + 120
    frame #5: 0x0000000108c0d924 libstatus.dylib`runtime.reflectcall + 52
    frame #6: 0x0000000108c44388 libstatus.dylib`reflect.Value.call + 2104

@status-im-auto
Copy link
Member

status-im-auto commented Mar 12, 2024 •
edited

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4797a93 #1 2024-03-12 15:12:33 ~6 min tests/nim 📄log
✔️ 4797a93 #1 2024-03-12 15:15:30 ~9 min macos/aarch64 🍎dmg
✔️ 4797a93 #1 2024-03-12 15:16:50 ~10 min tests/ui 📄log
✔️ 4797a93 #1 2024-03-12 15:18:30 ~12 min macos/x86_64 🍎dmg
✔️ 4797a93 #1 2024-03-12 15:21:47 ~15 min linux/x86_64 📦tgz
✔️ 4797a93 #1 2024-03-12 15:30:31 ~24 min windows/x86_64 💿exe
✔️ 11bacf7 #2 2024-03-13 12:24:20 ~6 min tests/nim 📄log
✔️ 11bacf7 #2 2024-03-13 12:24:43 ~6 min macos/aarch64 🍎dmg
✔️ 11bacf7 #2 2024-03-13 12:25:27 ~7 min macos/x86_64 🍎dmg
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 61507ab #3 2024-03-13 12:33:40 ~6 min macos/aarch64 🍎dmg
✔️ 61507ab #3 2024-03-13 12:34:27 ~6 min tests/nim 📄log
✔️ 61507ab #3 2024-03-13 12:34:36 ~6 min macos/x86_64 🍎dmg
✔️ 61507ab #3 2024-03-13 12:38:47 ~11 min tests/ui 📄log
✔️ 61507ab #3 2024-03-13 12:44:19 ~16 min linux/x86_64 📦tgz
✔️ 61507ab #3 2024-03-13 12:58:08 ~30 min windows/x86_64 💿exe
✔️ a2a769d #4 2024-03-13 15:30:54 ~6 min tests/nim 📄log
✔️ a2a769d #4 2024-03-13 15:32:04 ~7 min macos/x86_64 🍎dmg
✔️ a2a769d #4 2024-03-13 15:32:36 ~8 min macos/aarch64 🍎dmg
✔️ a2a769d #4 2024-03-13 15:35:13 ~10 min tests/ui 📄log
✔️ a2a769d #4 2024-03-13 15:39:22 ~15 min linux/x86_64 📦tgz
✔️ a2a769d #4 2024-03-13 15:52:53 ~28 min windows/x86_64 💿exe

@MishkaRogachev
Copy link
Contributor

IsDisplayNameDupeOfCommunityMember

let me check..

@alexjba alexjba force-pushed the fix/display_name_validation branch from 4797a93 to 11bacf7 Compare March 13, 2024 12:17
@alexjba
Copy link
Contributor Author

alexjba commented Mar 13, 2024

@MishkaRogachev Looks like something's wrong with the display name validation. I've integrated the display name validation in the UI, but status-go is crashing

DBG 2024-03-12 16:54:49.592+02:00 NewBE_callPrivateRPC                       topics="rpc" tid=35611638 file=core.nim:27 rpc_method=wakuext_isDisplayNameDupeOfCommunityMember
Process 99363 stopped
* thread #75, stop reason = EXC_BAD_ACCESS (code=1, address=0x80)
    frame #0: 0x000000010a34f004 libstatus.dylib`github.com/status-im/status-go/protocol.(*Messenger).IsDisplayNameDupeOfCommunityMember + 452
libstatus.dylib`github.com/status-im/status-go/protocol.(*Messenger).IsDisplayNameDupeOfCommunityMember:
->  0x10a34f004 <+452>: ldr    x1, [x0, #0x80]
    0x10a34f008 <+456>: ldr    x0, [x0, #0x78]
    0x10a34f00c <+460>: ldr    x3, [sp, #0x108]
    0x10a34f010 <+464>: cmp    x3, x1
Target 0: (nim_status_client) stopped.
(lldb) bt
* thread #75, stop reason = EXC_BAD_ACCESS (code=1, address=0x80)
  * frame #0: 0x000000010a34f004 libstatus.dylib`github.com/status-im/status-go/protocol.(*Messenger).IsDisplayNameDupeOfCommunityMember + 452
    frame #1: 0x000000010a4ab3e4 libstatus.dylib`github.com/status-im/status-go/services/wakuv2ext.(*PublicAPI).IsDisplayNameDupeOfCommunityMember + 52
    frame #2: 0x0000000108c09458 libstatus.dylib`runtime.call32.abi0 + 120
    frame #3: 0x0000000108c09458 libstatus.dylib`runtime.call32.abi0 + 120
    frame #4: 0x0000000108c09458 libstatus.dylib`runtime.call32.abi0 + 120
    frame #5: 0x0000000108c0d924 libstatus.dylib`runtime.reflectcall + 52
    frame #6: 0x0000000108c44388 libstatus.dylib`reflect.Value.call + 2104

Fixed after rebase

@alexjba alexjba force-pushed the fix/display_name_validation branch from 11bacf7 to 61507ab Compare March 13, 2024 12:27
@alexjba alexjba marked this pull request as ready for review March 13, 2024 12:27
MishkaRogachev
MishkaRogachev approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested

@alexjba alexjba force-pushed the fix/display_name_validation branch from 61507ab to a2a769d Compare March 13, 2024 15:24
@alexjba alexjba merged commit 4ca7e9b into master Mar 14, 2024
8 checks passed
@alexjba alexjba deleted the fix/display_name_validation branch March 14, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishkaRogachev MishkaRogachev MishkaRogachev approved these changes

@caybro caybro caybro approved these changes

@alexandraB99 alexandraB99 Awaiting requested review from alexandraB99

@noeliaSD noeliaSD Awaiting requested review from noeliaSD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexjba @status-im-auto @MishkaRogachev @caybro