chore(nim): use compile-time string formatting #13945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nim 2.2 comes with compile-time string formatting that doesn't raise exceptions if the format string is invalid - instead a compile-time error is given. This PR introduces a backport of that feature which improves performance and reduces the risk that formatting causes the app to crash and will help migrating the codebase to newer nim versions that track exceptions more carefully. There should be no change in runtime behavior (except formatting being a bit faster)
Jenkins Builds
|
jrainville
approved these changes
Mar 13, 2024
igor-sirotin
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nim 2.2 comes with compile-time string formatting that doesn't raise exceptions if the format string is invalid - instead a compile-time error is given.
This PR introduces a backport of that feature which improves performance and reduces the risk that formatting causes the app to crash and will help migrating the codebase to newer nim versions that track exceptions more carefully.
There should be no change in runtime behavior (except formatting being a bit faster)