Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump status-go (#13940) #13947

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: bump status-go (#13940) #13947

merged 1 commit into from
Mar 13, 2024

Conversation

MishkaRogachev
Copy link
Contributor

Close #13940
Waits status-im/status-go#4917

What does the PR do

Update status-go on capitalised wallet addresses comparison durning collectibles validation

Affected areas

Profile

Screenshot of functionality

Screen.Recording.2024-03-13.at.11.05.30.mov

@MishkaRogachev MishkaRogachev linked an issue Mar 13, 2024 that may be closed by this pull request
Can't save profile showcase preferences with a collectible #13940
Closed
@MishkaRogachev MishkaRogachev mentioned this pull request Mar 13, 2024
Merged
@status-im-auto
Copy link
Member

status-im-auto commented Mar 13, 2024 •
edited

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 61627eb #1 2024-03-13 10:23:18 ~6 min tests/nim 📄log
✔️ 61627eb #1 2024-03-13 10:27:14 ~10 min macos/x86_64 🍎dmg
✔️ 61627eb #1 2024-03-13 10:27:27 ~10 min macos/aarch64 🍎dmg
✔️ 61627eb #1 2024-03-13 10:27:28 ~10 min tests/ui 📄log
✔️ 61627eb #1 2024-03-13 10:33:03 ~16 min linux/x86_64 📦tgz
✔️ 61627eb #1 2024-03-13 10:47:02 ~30 min windows/x86_64 💿exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 32819c7 #2 2024-03-13 14:29:22 ~6 min tests/nim 📄log
✔️ 32819c7 #2 2024-03-13 14:30:18 ~7 min macos/aarch64 🍎dmg
✔️ 32819c7 #2 2024-03-13 14:30:53 ~7 min macos/x86_64 🍎dmg
❌ 32819c7 #2 2024-03-13 14:34:11 ~11 min tests/ui 📄log
✔️ 32819c7 #2 2024-03-13 14:40:23 ~17 min linux/x86_64 📦tgz
✔️ 32819c7 #2 2024-03-13 14:58:50 ~35 min windows/x86_64 💿exe
✔️ a30187a #3 2024-03-13 15:09:09 ~7 min tests/nim 📄log
✔️ a30187a #3 2024-03-13 15:09:38 ~7 min macos/aarch64 🍎dmg
✔️ a30187a #3 2024-03-13 15:10:01 ~7 min macos/x86_64 🍎dmg
✔️ a30187a #3 2024-03-13 15:14:01 ~12 min tests/ui 📄log
✔️ a30187a #3 2024-03-13 15:19:19 ~17 min linux/x86_64 📦tgz
✔️ a30187a #3 2024-03-13 15:31:09 ~29 min windows/x86_64 💿exe

alexjba
alexjba approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Tested and it works! 👍

@MishkaRogachev MishkaRogachev force-pushed the fix/13940-cant-save-profile-showcase-preferences-with-a-collectible branch from 61627eb to 32819c7 Compare March 13, 2024 14:22
@MishkaRogachev MishkaRogachev force-pushed the fix/13940-cant-save-profile-showcase-preferences-with-a-collectible branch from 32819c7 to a30187a Compare March 13, 2024 15:01
@MishkaRogachev MishkaRogachev merged commit 9596e3c into master Mar 13, 2024
8 checks passed
@MishkaRogachev MishkaRogachev deleted the fix/13940-cant-save-profile-showcase-preferences-with-a-collectible branch March 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@alexjba alexjba alexjba approved these changes

@noeliaSD noeliaSD Awaiting requested review from noeliaSD

Assignees
No one assigned
Labels
waiting-for-status-go-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't save profile showcase preferences with a collectible
4 participants
@MishkaRogachev @status-im-auto @caybro @alexjba