feat(CollectiblesLayout): Always visualize section header if community minted collectibles are present #13948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntax Syntax error.
It was missing a correct type in a balance item so it was causing a waring.
Specified text width to correctly elide on the right.
…minted collectibles are present - If only minted collectibles, section header visible. Otherwise, if only regular collectibles, section hidden. - Updated header used to `FoldableHeader`. Closes #13315
Jenkins Builds
|
dlipicar
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13315
What does the PR do
It closes previous mentioned issue but also some other fixes:
CollectiblesViewcaused by a wrong syntax.Affected areas
Main wallet collectibles layout
Screenshot of functionality
Before:
After:
Community tag:
Header visible/hidden depending on collectibles type:
Screen.Recording.2024-03-13.at.11.24.17.mov