Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings) fix popup spacing for change password modal #13987

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Mar 15, 2024

Closes: #13894

The extra space was not needed given that modal has a padding of 16 already

Design Implementation
image image

The extra space was not needed given that modal has a padding of 16
already

Closes: #13894
@status-im-auto
Copy link
Member

status-im-auto commented Mar 15, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e1dc02d #1 2024-03-15 09:52:16 ~6 min tests/nim 📄log
✔️ e1dc02d #1 2024-03-15 09:52:36 ~6 min macos/aarch64 🍎dmg
✔️ e1dc02d #1 2024-03-15 09:56:09 ~9 min macos/x86_64 🍎dmg
✔️ e1dc02d #1 2024-03-15 09:57:44 ~11 min tests/ui 📄log
✔️ e1dc02d #1 2024-03-15 10:03:19 ~17 min linux/x86_64 📦tgz
✔️ e1dc02d #1 2024-03-15 10:20:19 ~34 min windows/x86_64 💿exe

@stefandunca stefandunca merged commit 79fa379 into master Mar 15, 2024
8 checks passed
@stefandunca stefandunca deleted the fix_password_popup_spacing-13894 branch March 15, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Password settings flow]Make the modal on password change looks exactly like design
4 participants