Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qml): fix etherscan links for all networks #13999

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix(qml): fix etherscan links for all networks #13999

merged 2 commits into from
Mar 19, 2024

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Mar 15, 2024 •
edited

Closes: #13986

Also

  • refactor code for reusability and readability.
  • fix storybook to test the links in transaction details view

@status-im-auto
Copy link
Member

status-im-auto commented Mar 15, 2024 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 966cceb #2 2024-03-15 16:56:03 ~6 min tests/nim 📄log
✔️ 966cceb #2 2024-03-15 16:56:17 ~6 min macos/aarch64 🍎dmg
✔️ 966cceb #2 2024-03-15 17:00:04 ~10 min macos/x86_64 🍎dmg
✔️ 966cceb #2 2024-03-15 17:00:50 ~10 min tests/ui 📄log
✔️ 966cceb #2 2024-03-15 17:05:22 ~15 min linux/x86_64 📦tgz
✔️ 966cceb #2 2024-03-15 17:18:40 ~28 min windows/x86_64 💿exe
✔️ 19328c3 #3 2024-03-19 13:54:13 ~6 min tests/nim 📄log
✔️ 19328c3 #3 2024-03-19 13:57:07 ~8 min macos/aarch64 🍎dmg
✔️ 19328c3 #3 2024-03-19 13:57:50 ~9 min macos/x86_64 🍎dmg
✔️ 19328c3 #3 2024-03-19 13:59:14 ~11 min tests/ui 📄log
✔️ 19328c3 #3 2024-03-19 14:02:15 ~14 min linux/x86_64 📦tgz
✔️ 19328c3 #3 2024-03-19 14:13:08 ~24 min windows/x86_64 💿exe

Cuteivist
Cuteivist approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Cuteivist Cuteivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Khushboo-dev-cpp
Khushboo-dev-cpp approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefandunca stefandunca merged commit 0958860 into master Mar 19, 2024
8 checks passed
@stefandunca stefandunca deleted the fix_links-13986 branch March 19, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipicar dlipicar dlipicar approved these changes

@Cuteivist Cuteivist Cuteivist approved these changes

@Khushboo-dev-cpp Khushboo-dev-cpp Khushboo-dev-cpp approved these changes

@alaibe alaibe Awaiting requested review from alaibe

@caybro caybro Awaiting requested review from caybro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix all view on etherscan link
5 participants
@stefandunca @status-im-auto @dlipicar @Cuteivist @Khushboo-dev-cpp