Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ShareProfileDialog): contents spills outside of dialog #14003

Conversation

caybro
Copy link
Member

@caybro caybro commented Mar 17, 2024

What does the PR do

  • make the contents scrollable using a StatusScrollView

Fixes #13967

Affected areas

ShareProfileDialog

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Zaznam.obrazovky.z.2024-03-17.11-37-49.webm

@status-im-auto
Copy link
Member

status-im-auto commented Mar 17, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fd738cb #1 2024-03-17 10:44:18 ~5 min tests/nim 📄log
✔️ fd738cb #1 2024-03-17 10:45:18 ~6 min macos/aarch64 🍎dmg
✔️ fd738cb #1 2024-03-17 10:49:24 ~10 min tests/ui 📄log
✔️ fd738cb #1 2024-03-17 10:49:31 ~10 min macos/x86_64 🍎dmg
✔️ fd738cb #1 2024-03-17 10:54:19 ~15 min linux/x86_64 📦tgz
✔️ fd738cb #1 2024-03-17 11:08:06 ~29 min windows/x86_64 💿exe
✔️ 9039610 #2 2024-03-18 22:39:27 ~5 min macos/aarch64 🍎dmg
✔️ 9039610 #2 2024-03-18 22:40:25 ~6 min tests/nim 📄log
✔️ 9039610 #2 2024-03-18 22:43:39 ~9 min macos/x86_64 🍎dmg
✔️ 9039610 #2 2024-03-18 22:45:20 ~10 min tests/ui 📄log
✔️ 9039610 #2 2024-03-18 22:49:01 ~14 min linux/x86_64 📦tgz
✔️ 9039610 #2 2024-03-18 23:01:20 ~26 min windows/x86_64 💿exe

@caybro caybro requested a review from micieslak March 18, 2024 08:43
- make the contents scrollable using a `StatusScrollView`

Fixes #13967
@caybro caybro force-pushed the 13967-share-dialog-content-of-dialog-spills-outside-of-dialog-boundary-when-app-window-resized-to-min-height branch from fd738cb to 9039610 Compare March 18, 2024 22:34
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caybro caybro merged commit 864be0a into master Mar 19, 2024
8 checks passed
@caybro caybro deleted the 13967-share-dialog-content-of-dialog-spills-outside-of-dialog-boundary-when-app-window-resized-to-min-height branch March 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share dialog: content of dialog spills outside of dialog boundary when app window resized to min height
4 participants