fix(WalletView): Apply to my wallet doesn't save or apply the order
#14018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
changed the title
Apply to my wallet doesn't save or apply the order
Jenkins Builds
|
1 task
2 tasks
noeliaSD
approved these changes
Mar 18, 2024
| @@ -71,9 +71,10 @@ SettingsContentBase { | |||
| manageTokensView.saveChanges() | |||
| } | |||
| onSaveChangesClicked: { | |||
| manageTokensView.saveChanges() | |||
There was a problem hiding this comment.
I'm wondering which is the difference between onSaveForLaterClicked and onSaveChangesClicked in terms of "saving changes".. For me, the difference should be.. onSaveChangesClicked should directly apply the new settings and set as well the order to the custom one, otherwise, this save for later doesn't have any sense to me... I think this is a point for future discussion, probably discussion with design team.
There was a problem hiding this comment.
We discussed this already several times 😁 The current behavior is correct; the "Save for later" option just saves the Custom order but doesn't set it for the main wallet view
- we _always_ want to save the changes, it's the toasts that we don't want to see when looking at the Advanced tab Fixes #14016
caybro
force-pushed
the
14016-token-management-apply-to-wallet-doesnt-apply-the-order
branch
from
cfb8132
to
9260910
Compare
Cuteivist
approved these changes
Mar 19, 2024
alexjba
approved these changes
Mar 19, 2024
caybro
deleted the
14016-token-management-apply-to-wallet-doesnt-apply-the-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #14016
Affected areas
Settings/Wallet/Manage tokens
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-03-18.19-01-24.webm