fix(@desktop/wallet): Fix link out to blockchain explorer from collectibles details view #14027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
force-pushed
the
fix/collectibleDetailsEtherscanLinkOut
branch
from
00fcd5d
to
ab6607c
Compare
Jenkins BuildsClick to see older builds (6)
|
Khushboo-dev-cpp
force-pushed
the
fix/collectibleDetailsEtherscanLinkOut
branch
from
ab6607c
to
9048126
Compare
stefandunca
force-pushed
the
fix_links-13986
branch
from
966cceb
to
19328c3
Compare
Khushboo-dev-cpp
force-pushed
the
fix/collectibleDetailsEtherscanLinkOut
branch
from
9048126
to
4b7b3d1
Compare
Khushboo-dev-cpp
requested review from
caybro,
noeliaSD,
Cuteivist and
IvanBelyakoff
dlipicar
reviewed
Mar 20, 2024
| @@ -488,16 +488,39 @@ QtObject { | |||
| return root.mainModuleInst.addressWasShown(address) | |||
| } | |||
|
|
|||
| function getExplorerUrl() { | |||
| function getExplorerUrl(networkShortName, contractAddress, tokenId) { | |||
There was a problem hiding this comment.
hmm better use the chainID itself instead of the shortname as parameter IMO
the Collectible entry exposes that property
And by using that we don't have to go checking if testnet and Goerli are toggled on or off in the settings, it's explicit already. Makes more sense to me since there's a 1-1 chainID<->explorerAddress relation
There was a problem hiding this comment.
Hey @dlipicar I guess it better to use short name because it would be the same for testnet and mainnet while the chainIds would differ in both cases. This helps us make the code shorter in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@desktop/wallet): Fix link out to blockchain explorer from collectibles details view
What does the PR do
Fixes the url to link out to a blockchain explorer from the collectible detailsview
Affected areas
CollectibleDetailsView
StatusQ checklist
Screenshot of functionality (including design for comparison)
Mainnet linkout
Screen.Recording.2024-03-19.at.10.55.12.AM.mov
Testnet linkout
Screen.Recording.2024-03-19.at.10.54.20.AM.mov