Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: force some warnings as errors #14068

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented Mar 20, 2024

What does the PR do

  1. Added a workaround to make --warningAsError work.
    Context: Warning is ignored when using flags --warningAsError and --verbosity together nim-lang/Nim#23429

  2. Moved config parameters to config.nims

  3. Removed some unused imports.

@status-im-auto
Copy link
Member

status-im-auto commented Mar 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f3b422c #1 2024-03-20 18:43:30 ~6 min tests/nim 📄log
✔️ f3b422c #1 2024-03-20 18:44:24 ~7 min macos/aarch64 🍎dmg
✔️ f3b422c #1 2024-03-20 18:46:44 ~10 min macos/x86_64 🍎dmg
✔️ f3b422c #1 2024-03-20 18:47:32 ~10 min tests/ui 📄log
✔️ f3b422c #1 2024-03-20 18:54:03 ~17 min linux/x86_64 📦tgz
✔️ f3b422c #1 2024-03-20 19:06:25 ~29 min windows/x86_64 💿exe

Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah! I like the new restrictions

@igor-sirotin igor-sirotin merged commit a2af01b into master Mar 20, 2024
8 checks passed
@igor-sirotin igor-sirotin deleted the fix/force-warnings-as-errors branch March 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants