Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add perspective combo box #14145

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Feat/add perspective combo box #14145

merged 2 commits into from
Apr 2, 2024

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Mar 25, 2024 •
edited
Loading

What does the PR do

Closes #13424

Changes:

  1. Adding a new component ProfilePerspectiveSelector + storybook c9ecde1
  2. Integrate the selector in MyProfilePreview and ProfileDialog c16a3b6

Affected areas

Profile dialog
Profile showcase

Screenshot of functionality (including design for comparison)

Screen.Recording.2024-03-25.at.15.54.34.mov

@alexjba alexjba marked this pull request as ready for review March 25, 2024 13:56
@status-im-auto
Copy link
Member

status-im-auto commented Mar 25, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c16a3b6 #1 2024-03-25 14:01:04 ~7 min tests/nim 📄log
✔️ c16a3b6 #1 2024-03-25 14:04:29 ~10 min macos/x86_64 🍎dmg
✔️ c16a3b6 #1 2024-03-25 14:05:32 ~11 min tests/ui 📄log
✔️ c16a3b6 #1 2024-03-25 14:11:16 ~17 min macos/aarch64 🍎dmg
✔️ c16a3b6 #1 2024-03-25 14:11:44 ~17 min linux/x86_64 📦tgz
✔️ c16a3b6 #1 2024-03-25 14:27:45 ~33 min windows/x86_64 💿exe
✔️ c16a3b6 #2 2024-03-29 11:48:45 ~4 min macos/aarch64 🍎dmg
✔️ c16a3b6 #2 2024-03-29 11:50:37 ~6 min tests/nim 📄log
❌ c16a3b6 #2 2024-03-29 11:55:45 ~11 min tests/ui 📄log
✔️ c16a3b6 #2 2024-03-29 11:56:55 ~12 min macos/x86_64 🍎dmg
✔️ c16a3b6 #2 2024-03-29 12:00:33 ~16 min linux/x86_64 📦tgz
✔️ c16a3b6 #2 2024-03-29 12:08:11 ~24 min windows/x86_64 💿exe
✔️ 08eac9b #3 2024-03-29 13:34:23 ~4 min macos/aarch64 🍎dmg
✔️ 08eac9b #3 2024-03-29 13:36:20 ~6 min tests/nim 📄log
✔️ 08eac9b #3 2024-03-29 13:37:25 ~7 min macos/x86_64 🍎dmg
✔️ 08eac9b #3 2024-03-29 13:40:02 ~10 min tests/ui 📄log
✔️ 08eac9b #3 2024-03-29 13:45:48 ~16 min linux/x86_64 📦tgz
✔️ 08eac9b #3 2024-03-29 14:01:21 ~31 min windows/x86_64 💿exe

@MishkaRogachev MishkaRogachev force-pushed the feat/13908-dedicated-backend-for-contacts-profile-showcase branch 4 times, most recently from 400adce to 41662ca Compare March 28, 2024 13:37
noeliaSD
noeliaSD reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector looks really nice!!

Tested both the dialog and the sideBySidePreview ones, data is correctly filtered out depending on the visibility level but there's an issue with the sideBySidePreview size:

Screen.Recording.2024-03-28.at.16.31.56.mov

@MishkaRogachev MishkaRogachev force-pushed the feat/13908-dedicated-backend-for-contacts-profile-showcase branch 2 times, most recently from feb58c2 to eda6134 Compare March 28, 2024 17:27
Base automatically changed from feat/13908-dedicated-backend-for-contacts-profile-showcase to master March 29, 2024 11:43
@alexjba alexjba force-pushed the feat/add-perspective-combo-box branch from c16a3b6 to 08eac9b Compare March 29, 2024 13:29
@alexjba
Copy link
Contributor Author

alexjba commented Mar 29, 2024

The selector looks really nice!!

Tested both the dialog and the sideBySidePreview ones, data is correctly filtered out depending on the visibility level but there's an issue with the sideBySidePreview size:

Screen.Recording.2024-03-28.at.16.31.56.mov

Fixed

caybro
caybro approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

noeliaSD
noeliaSD approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again! Thanks for the fix!! LGTM!

@alexjba alexjba merged commit 1d45243 into master Apr 2, 2024
8 checks passed
@alexjba alexjba deleted the feat/add-perspective-combo-box branch April 2, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@noeliaSD noeliaSD noeliaSD approved these changes

@micieslak micieslak Awaiting requested review from micieslak

@alexandraB99 alexandraB99 Awaiting requested review from alexandraB99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Profile Showcase - Profile Popup] "Preview as ..." aspect combobox
4 participants
@alexjba @status-im-auto @caybro @noeliaSD