Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/13631 red dot token delegate #14159

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix/13631 red dot token delegate #14159

merged 1 commit into from
Mar 27, 2024

Conversation

Cuteivist
Copy link
Contributor

Cherrypick of #14061

@status-im-auto
Copy link
Member

status-im-auto commented Mar 26, 2024 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 33222d3 #1 2024-03-26 07:19:14 ~6 min tests/nim 📄log
✔️ 33222d3 #1 2024-03-26 07:20:11 ~7 min macos/aarch64 🍎dmg
✔️ 33222d3 #1 2024-03-26 07:24:24 ~11 min tests/ui 📄log
✔️ 33222d3 #1 2024-03-26 07:27:44 ~14 min macos/x86_64 🍎dmg
✔️ 33222d3 #1 2024-03-26 07:29:46 ~16 min linux/x86_64 📦tgz
✔️ 33222d3 #1 2024-03-26 07:46:05 ~33 min windows/x86_64 💿exe
❌ 04a2861 #3 2024-03-26 15:58:10 ~4 min windows/x86_64 📄log
✔️ 04a2861 #3 2024-03-26 15:59:41 ~6 min tests/nim 📄log
✔️ 04a2861 #3 2024-03-26 15:59:56 ~6 min macos/aarch64 🍎dmg
✔️ 04a2861 #3 2024-03-26 16:04:26 ~10 min tests/ui 📄log
✔️ 04a2861 #3 2024-03-26 16:06:29 ~12 min macos/x86_64 🍎dmg
✔️ 04a2861 #3 2024-03-26 16:09:13 ~15 min linux/x86_64 📦tgz
✔️ 04a2861 #4 2024-03-26 16:27:39 ~24 min windows/x86_64 💿exe

Khushboo-dev-cpp
Khushboo-dev-cpp approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cuteivist Cuteivist force-pushed the fix/13631-red-dot-token-delegate branch from 33222d3 to c46a540 Compare March 26, 2024 15:52
@Cuteivist Cuteivist force-pushed the fix/13631-red-dot-token-delegate branch from c46a540 to 04a2861 Compare March 26, 2024 15:53
@iurimatias iurimatias merged commit 1a0900a into release/2.28.x Mar 27, 2024
8 checks passed
@iurimatias iurimatias deleted the fix/13631-red-dot-token-delegate branch March 27, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caybro caybro caybro approved these changes

@Khushboo-dev-cpp Khushboo-dev-cpp Khushboo-dev-cpp approved these changes

@alaibe alaibe Awaiting requested review from alaibe

@IvanBelyakoff IvanBelyakoff Awaiting requested review from IvanBelyakoff

@stefandunca stefandunca Awaiting requested review from stefandunca

@noeliaSD noeliaSD Awaiting requested review from noeliaSD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Cuteivist @status-im-auto @caybro @Khushboo-dev-cpp @iurimatias