fix(wallet): Update balance loading state on token fetched #14491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
caybro,
IvanBelyakoff,
alexjba and
Khushboo-dev-cpp
Jenkins Builds
|
Cuteivist
force-pushed
the
bugfix/wallet-balance-14427
branch
from
0486448
to
b235bf4
Compare
caybro
approved these changes
Apr 19, 2024
| let loading = walletAccounts[0].assetsLoading or self.controller.getTokensMarketValuesLoading() | ||
| if walletAccounts.len == 0: | ||
| return | ||
| var loading = self.controller.getTokensMarketValuesLoading() |
There was a problem hiding this comment.
Suggested change
| var loading = self.controller.getTokensMarketValuesLoading() | |
| var loading = self.controller.getTokensMarketValuesLoading() or anyIt(walletAccounts, it.assetsLoading) |
alaibe
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14427
Closes #14514
What does the PR do
Affected areas
Wallet
Screenshot of functionality (including design for comparison)
2024-04-19_16-29-51.mp4