fix(CommunitiesModule): Qt props fixed to not crash MonitoringTool #14495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micieslak
requested review from
Seitseman,
caybro,
alexjba,
saledjenic and
noeliaSD
Jenkins Builds
|
micieslak
force-pushed
the
fix/issue-14493
branch
from
bea7808
to
21995b7
Compare
alexjba
approved these changes
Apr 23, 2024
caybro
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
There were 2 properties broken, but they weren't crashing the app because they weren't used. However it was a problem for Monitoring Tool reading all the exposed properties.
Closes: #14493
Affected areas
src/app/modules/main/communities/view.nim