fix: can't join an encrypted community #14518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
- fix the corner case and allow the user to join a community without an explicitely stated "Member" permission - enable/disable the Share/Join/Save buttons when the permission to join check is ongoing, or when the permission check failed - display tooltips over the disabled buttons explaining why it's disabled - always display the eligibility button floating on top of the (scrollable) contents Fixes #14473 Fixes #14299
caybro
force-pushed
the
14473-cant-join-an-encrypted-community
branch
from
b8037c2
to
1008058
Compare
MishkaRogachev
approved these changes
Apr 25, 2024
| loading: root.requirementsCheckPending | ||
| type: d.lostCommunityPermission || d.lostChannelPermissions ? StatusBaseButton.Type.Danger : StatusBaseButton.Type.Normal | ||
| tooltip.text: { | ||
| if (interactive) |
There was a problem hiding this comment.
is tooltip available if !interactive
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #14473
Fixes #14299
Affected areas
CommunityMembershipSetupDialog
Screenshot of functionality (including design for comparison)
Main join dialog:
Check over:
Editting addresses:
