Cherry-picks of hide create community button and disable archive #14565
Conversation
Jenkins BuildsClick to see older builds (6)
|
| id: createBtn | ||
| visible: communitiesStore.createCommunityEnabled || communitiesStore.testEnvironment |
There was a problem hiding this comment.
I just found out that the new e2e tests don't have this flag enabled now. Is there another flag I can use to show this button in tests? cc @anastasiyaig
Otherwise, we need to tweak the communities tests to set the setting to ON before creating the community and it seems like effort for nothing
There was a problem hiding this comment.
easiest solution now is to exclude the test from the run (which i already did). We need to fix the flow and i will be done ASAP and i will bring the test back when it is done
|
we don't yet. because there is no yet a flag :) but we can add it. i will check what could be done here |
Fixes #14530 (includes a revert of the previous hide that wasn't exactly what we wanted)
jrainville
force-pushed
the
chore/cherry-picks
branch
from
f2c9a5f
to
af3b2fe
Compare
|
Alright, thanks. I rebased. Let's see if it passes now. |
|
it will , it passed before your rebase, i checked :D |
|
It worked. Thanks @anastasiyaig |
Cherry picks of #14545 and #14547
Fixes #14534 and #14530