fix(BiometricLogin): Move to regular login page when biometric login fails with error

[alexjba]

What does the PR do

Closes #13046

Moving to regular login whenever the biometric login fails

Affected areas

Onboarding login flow

Screenshot of functionality (including design for comparison)

Screen.Recording.2024-05-20.at.15.44.37.mov

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	273aceb	#1	2024-05-20 13:02:07	~7 min	macos/aarch64	🍎dmg
✔️	273aceb	#1	2024-05-20 13:03:50	~9 min	tests/nim	📄log
✔️	273aceb	#1	2024-05-20 13:07:21	~12 min	macos/x86_64	🍎dmg
✔️	273aceb	#1	2024-05-20 13:13:04	~18 min	tests/ui	📄log
✔️	273aceb	#1	2024-05-20 13:17:42	~23 min	linux/x86_64	📦tgz
✔️	273aceb	#1	2024-05-20 13:30:06	~35 min	windows/x86_64	💿exe

[micieslak]

The flow here is not clear for me.

From the issue description I understand that the problem here is invisible error message in case of failed biometric login. But nothing about automatic switch to password mode. Isn't it confusing for potential user to switch automatically with no chance to do another attempt with biometrics and only optionally explicitly switch to password mode by clicking button?

[alexjba]

The flow here is not clear for me.

From the issue description I understand that the problem here is invisible error message in case of failed biometric login. But nothing about automatic switch to password mode. Isn't it confusing for potential user to switch automatically with no chance to do another attempt with biometrics and only optionally explicitly switch to password mode by clicking button?

Currently there is no option to retry the biometrics login. Once it fails the only option is to use the regular login. Not sure if it's something we're missing here.

@benjthayer could you help in reviewing the login flows when biometrics is used?

[micieslak]

The flow here is not clear for me.
From the issue description I understand that the problem here is invisible error message in case of failed biometric login. But nothing about automatic switch to password mode. Isn't it confusing for potential user to switch automatically with no chance to do another attempt with biometrics and only optionally explicitly switch to password mode by clicking button?

Currently there is no option to retry the biometrics login. Once it fails the only option is to use the regular login. Not sure if it's something we're missing here.

@benjthayer could you help in reviewing the login flows when biometrics is used?

For me it's a bit strange to see biometrics login error here in the password mode:

But maybe it's ok 🤷‍♂️

[alexjba]

@micieslak Maybe we should have a complete biometrics flow with error field and retry button. Although probably retying biometrics in case of error doesn't make sense because there's nothing the user can do to mitigate the error.

[saledjenic]

The error FOREIGN_KEYS PRAGMA doesn't look like keychain error.
Also keychain errors are handled differently.

We don't have a button on the UI login page like "run biometrics again", also not sure if we need it, but @benjthayer will confirm that.

After a user start the app the flow is:

• if the pass/pin is stored to a Keychain we should the OS' popup for the Keychain
  • if the user cancels the OS' popup for the Keychain, we automatically display an appropriate input for entering pass/pin
  • if the user successfully accesses the Keychain:
    • if the stored pass/pin is the correct one, the user is logged in
    • if the stored pass/pin is wrong, we should display a message about it and display an appropriate input for entering pass/pin (we can discuss this option, but I wouldn't offer user at this stage to update the pass/pin stored to the Keychain, but rather let him enter it and silently disable biometrics in the backed, that way when he wants to enable it again, will need to provide the correct pin/pass)
• if the pass/pin is not stored we should display an appropriate input for entering pass/pin