Save only the settings that are changed #14930
Conversation
friofry
requested review from
jrainville,
richard-ramos,
kounkou and
a team
and removed request for
jrainville,
richard-ramos and
kounkou
friofry
force-pushed
the
ab/issue-12918-setting-update-with-diffs
branch
from
3912dbb
to
32d14e3
Compare
|
@Seitseman check this out pls, I have a guts feeling this might actually also fix status-im/status-go#5186 |
Jenkins BuildsClick to see older builds (8)
|
yeah, also this improvement might fix the problem: #14813 |
|
FYI, could be related: #12918 |
| @@ -122,7 +122,7 @@ proc isNimbusProxyEnabled*(self: Controller): bool = | |||
| proc toggleNimbusProxy*(self: Controller) = | |||
| let enabled = self.nodeConfigurationService.isNimbusProxyEnabled() | |||
|
|
|||
| if(not self.nodeConfigurationService.setNimbusProxyConfig(not enabled)): | |||
| if not self.nodeConfigurationService.setNimbusProxyConfigEnabled(not enabled): | |||
There was a problem hiding this comment.
setNimbusProxyConfigEnabled is a setter that returns a boolean, what does it mean 😲 ? See comment below.
There was a problem hiding this comment.
a setter that returns a boolean, what does it mean
Sorry, not sure what you mean. I thought you had added this code. But I guess the purpose here is to handle status-go errors for whatever reason and log it
|
This PR indeed fixes the problem with Windows not logging in. LGTM |
Awesome! @friofry then we'll need to cherry-pick this PR to the release branch after |
|
Well, it looks like when I want to sync "this" app with other, and there is no data folder, status-im/status-go#5186 would still occur. And when I'm creating new user, it will still error out. So this PR is not fixing 5255 |
Ah ok. Then @friofry it's not necessary to cherry-pick |
friofry
force-pushed
the
ab/issue-12918-setting-update-with-diffs
branch
2 times, most recently
from
a266755
to
66189dc
Compare
* fix saveNewWakuNode in the settings * fix setNimbusProxyConfigEnabled in the settings * fix setLightMode in the settings
friofry
force-pushed
the
ab/issue-12918-setting-update-with-diffs
branch
from
66189dc
to
f246859
Compare
What does the PR do
status-go PR status-im/status-go#5237
fixes #12918 #14889
The main goal - remove all uses of
saveNodeConfiguration. Because it can overwrite the values it doesn't know about.(for example Fix(settings): crash when enabling history archive and disabling logs #14812)
Use instead: setLightClient, saveNewWakuNode, setMaxLogBackups (How many log files to keep archived setting is set to 0 #14889)
Affected areas
Settings, NodeConfig
Screenshot of functionality (including design for comparison)
settings.mp4
additional info
setNimbusProxyConfigEnabledcurrently is not used anywhere. Should be fixed after merging status-im/status-go#4254further improvements:
#14929