fix(signals_manager): ensure savedAddresses event has JNull check
#7888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's something off with the `savedAddresses` signal data, which causes it to be `JNull` instead of an empty array (`JArray`) and breaks signal decoding. Ultimately this should be fixed in status-go, but this unblocks Desktop.
Jenkins Builds
|
0x-r4bbit
added a commit
to status-im/status-go
that referenced
this pull request
Oct 13, 2022
Otherwise the json response will be `null` instead of an empty array (which broke desktop): status-im/status-desktop#7888
|
This PR here can be ignored if status-im/status-go#2906 lands first |
anastasiyaig
approved these changes
Oct 13, 2022
stefandunca
approved these changes
Oct 13, 2022
0x-r4bbit
added a commit
to status-im/status-go
that referenced
this pull request
Oct 13, 2022
Otherwise the json response will be `null` instead of an empty array (which broke desktop): status-im/status-desktop#7888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's something off with the
savedAddressessignal data, which causes it to beJNullinstead of an empty array (JArray) and breaks signal decoding.Ultimately this should be fixed in status-go, but this unblocks Desktop.