Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messagesView): Increase spacing between chat messages #8861

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Dec 20, 2022

What does the PR do

Fix #8675

Added padding between messages as specified in Figma:
topPadding - 8 if the current message has header, 2 otherwise
bottomPadding - 8 if both current and next message have header, 2 otherwise

Affected areas

MessageView
StatusMessage

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Screenshot 2022-12-20 at 15 23 22

Screenshot 2022-12-20 at 15 23 39

Screen.Recording.2022-12-20.at.15.15.49.mov

@status-im-auto
Copy link
Member

status-im-auto commented Dec 20, 2022

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3b72588 #1 2022-12-20 13:37:18 ~6 min imports 📄log
✔️ 3b72588 #1 2022-12-20 13:37:54 ~7 min linux-cpp 📄log
✔️ 3b72588 #1 2022-12-20 13:40:35 ~9 min macos 🍎dmg
✔️ 3b72588 #1 2022-12-20 13:44:56 ~14 min linux 📦tgz
✖️ 3b72588 #1 2022-12-20 13:49:10 ~18 min linux-e2e 📄log
✔️ 3b72588 #1 2022-12-20 13:55:12 ~24 min windows 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 22edbf2 #2 2022-12-21 15:08:50 ~4 min imports 📄log
✔️ 22edbf2 #2 2022-12-21 15:08:56 ~4 min linux-cpp 📄log
✔️ 22edbf2 #2 2022-12-21 15:11:33 ~7 min macos 🍎dmg
✔️ 22edbf2 #2 2022-12-21 15:13:33 ~9 min linux 📦tgz
✔️ 22edbf2 #2 2022-12-21 15:25:08 ~21 min windows 💿exe
✖️ 22edbf2 #2 2022-12-21 15:32:42 ~28 min linux-e2e 📄log
✔️ da0d1da #3 2022-12-23 10:04:20 ~2 min linux-cpp 📄log
✔️ da0d1da #3 2022-12-23 10:06:25 ~4 min imports 📄log
✔️ da0d1da #3 2022-12-23 10:10:45 ~9 min macos 🍎dmg
✔️ da0d1da #3 2022-12-23 10:13:00 ~11 min linux 📦tgz
✔️ da0d1da #3 2022-12-23 10:25:14 ~23 min windows 💿exe
✔️ da0d1da #3 2022-12-23 10:30:06 ~28 min linux-e2e 📄log

Added padding between messages as specified in Figma:
topPadding - 8 if the current message has header, 2 otherwise
bottomPadding - 8 if both current and next message have header, 2 otherwise
@alexjba alexjba merged commit 94b911a into master Dec 23, 2022
@alexjba alexjba deleted the fix/issue-8675 branch December 23, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase spacing between chat messages
4 participants