Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded postgres name/port #4040

Closed
igor-sirotin opened this issue Sep 18, 2023 · 1 comment · Fixed by #4041
Closed

Remove hard-coded postgres name/port #4040

igor-sirotin opened this issue Sep 18, 2023 · 1 comment · Fixed by #4041
Assignees

Comments

@igor-sirotin
Copy link
Contributor

Problem

Tests seems to be failing to run in parallel in CI:

docker: Error response from daemon: Conflict. The container name "/status-go-test-db" is already in use by container "2723e6e32c65e7a5130fe5ad94d63f3697608879a860dff2f714b71294fcc6dd". You have to remove (or rename) that container to be able to reuse that name.

Implementation

Parametrize:

  1. docker container name
    DB_CONT = 'status-go-test-db'
  2. postgres port
    DefaultTestURI = "postgres://postgres@127.0.0.1:5432/postgres?sslmode=disable"
    DropTableURI = "postgres://postgres@127.0.0.1:5432/template1?sslmode=disable"
@igor-sirotin
Copy link
Contributor Author

cc @jakubgs

@igor-sirotin igor-sirotin changed the title Remove postgres hard-coded name/port Remove hard-coded postgres name/port Sep 18, 2023
@jakubgs jakubgs self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants