Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: parametrize DB port for unit tests #4041

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Sep 18, 2023

Otherwise we can't run tests in parallel on the same host. Also the container name has to be different depending on executor.

Resolves errors like:

docker: Error response from daemon: Conflict.
    The container name "/status-go-test-db" is already in use by container "123...".
    You have to remove (or rename) that container to be able to reuse that name.

Resolves: #4040

@status-im-auto
Copy link
Member

status-im-auto commented Sep 18, 2023

Jenkins Builds

Click to see older builds (19)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fe7051e #1 2023-09-18 15:55:57 ~2 min linux 📦zip
✔️ fe7051e #1 2023-09-18 15:57:37 ~4 min ios 📦zip
✔️ fe7051e #1 2023-09-18 15:58:04 ~5 min android 📦aar
✔️ 94ef070 #2 2023-09-18 16:00:05 ~1 min android 📦aar
✖️ 94ef070 #2 2023-09-18 16:00:55 ~2 min tests 📄log
✔️ 94ef070 #2 2023-09-18 16:01:10 ~2 min ios 📦zip
✔️ 94ef070 #2 2023-09-18 16:01:51 ~3 min linux 📦zip
✖️ 39bb8f9 #3 2023-09-18 16:03:54 ~52 sec tests 📄log
✔️ 39bb8f9 #3 2023-09-18 16:04:08 ~1 min linux 📦zip
✔️ 39bb8f9 #3 2023-09-18 16:04:18 ~1 min android 📦aar
✔️ 39bb8f9 #3 2023-09-18 16:05:39 ~2 min ios 📦zip
✔️ 6a5c55b #4 2023-09-18 16:05:34 ~1 min linux 📦zip
✔️ 6a5c55b #4 2023-09-18 16:05:55 ~1 min android 📦aar
✖️ 6a5c55b #4 2023-09-18 16:08:13 ~3 min tests 📄log
✔️ 6a5c55b #4 2023-09-18 16:08:15 ~2 min ios 📦zip
✔️ 843b831 #5 2023-09-18 16:42:22 ~1 min linux 📦zip
✔️ 843b831 #5 2023-09-18 16:43:49 ~2 min ios 📦zip
✖️ 843b831 #5 2023-09-18 16:46:21 ~5 min tests 📄log
✔️ 843b831 #5 2023-09-18 16:46:23 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0b66189 #6 2023-09-18 16:55:31 ~1 min linux 📦zip
✔️ 0b66189 #6 2023-09-18 16:55:42 ~1 min android 📦aar
✔️ 0b66189 #6 2023-09-18 16:57:01 ~2 min ios 📦zip
✖️ 0b66189 #6 2023-09-18 17:22:05 ~27 min tests 📄log
✔️ 494c670 #7 2023-09-18 17:56:27 ~1 min linux 📦zip
✔️ 494c670 #7 2023-09-18 17:56:34 ~1 min android 📦aar
✔️ 494c670 #7 2023-09-18 17:57:57 ~2 min ios 📦zip
✔️ 494c670 #7 2023-09-18 18:24:17 ~29 min tests 📄log

@jakubgs jakubgs force-pushed the ci/fix-unit-test-db-port branch 5 times, most recently from 843b831 to 0b66189 Compare September 18, 2023 16:54
Otherwise we can't run tests in parallel on the same host. Also the
container name has to be different depending on executor.

Resolves errors like:
```
docker: Error response from daemon: Conflict.
    The container name "/status-go-test-db" is already in use by container "123...".
    You have to remove (or rename) that container to be able to reuse that name.
```
Resolves: #4040

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jakubgs jakubgs merged commit 494c670 into develop Sep 18, 2023
7 checks passed
@jakubgs jakubgs deleted the ci/fix-unit-test-db-port branch September 18, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard-coded postgres name/port
4 participants