chore(wallet)_: unit tests for SendTransaction, transaction manager API cleanup #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (42)
|
IvanBelyakoff
changed the title
IvanBelyakoff
force-pushed
the
test/send_transaction
branch
2 times, most recently
from
766084b
to
62d2114
Compare
IvanBelyakoff
changed the title
IvanBelyakoff
force-pushed
the
test/send_transaction
branch
from
4f834cb
to
c86f59a
Compare
IvanBelyakoff
force-pushed
the
test/send_transaction
branch
3 times, most recently
from
3a91b00
to
b3a3909
Compare
saledjenic
approved these changes
May 29, 2024
There was a problem hiding this comment.
@IvanBelyakoff nice separation and a good step forward towards testing transactions part.
IvanBelyakoff
force-pushed
the
test/send_transaction
branch
from
b3a3909
to
2a5f67d
Compare
- exported API methods left at the same place - private methods moved to helpers.go - stuff for testing moved to testutils.go - created storage interface with clean API and multi transaction related db calls moved to MultiTransactionDBStorage implementation - created dummy in-mem storage for tests with multi transactions - written tests for MultiTransactionDBStorage
IvanBelyakoff
force-pushed
the
test/send_transaction
branch
from
2a5f67d
to
eec24a5
Compare
- Moved some methods from Transactor to users of it to clean interface. - Mocked Bridge interface and Transactor interface for tests - Wrote unit tests for SendTransaction
IvanBelyakoff
force-pushed
the
test/send_transaction
branch
from
eec24a5
to
5b553dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements in code structure to make package more clean and testable:
Test related changes:
TransactionManager.SendTransactionsmethodCloses #5148