Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message cache hits SQL error #2374

Merged
merged 1 commit into from Sep 22, 2021
Merged

fix: message cache hits SQL error #2374

merged 1 commit into from Sep 22, 2021

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Sep 21, 2021 •
edited

fixes this error:

t=2021-09-21T10:34:30-0400 lvl=eror msg="failed to check messages exists" namespace=Transport error="too many SQL variables"
t=2021-09-21T10:34:30-0400 lvl=eror msg="failed to retrieve raw messages" err="too many SQL variables"

which happens when using +999 "?" placeholders

@status-github-bot
Copy link

status-github-bot bot commented Sep 21, 2021 •
edited by richard-ramos

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@richard-ramos richard-ramos changed the title Fix/message cache hits fix: message cache hits SQL error Sep 21, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Sep 21, 2021 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 94dfecd #1 2021-09-21 15:21:53 ~4 min ios 📦zip
✔️ 94dfecd #1 2021-09-21 15:22:11 ~4 min linux 📦zip
✔️ 94dfecd #1 2021-09-21 15:26:48 ~9 min android 📦aar
✔️ 7bfe7e7 #2 2021-09-21 15:29:07 ~6 min ios 📦zip
✔️ 7bfe7e7 #2 2021-09-21 15:30:30 ~7 min linux 📦zip
✔️ 7bfe7e7 #2 2021-09-21 15:37:07 ~10 min android 📦aar

@status-im-auto
Copy link
Member

✔️ status-go/prs/linux/PR-2374#2 🔹 ~8 min 31 sec 🔹 7bfe7e7 🔹 📦 linux package

@richard-ramos richard-ramos merged commit a8a5aca into develop Sep 22, 2021
@richard-ramos richard-ramos deleted the fix/message-cache-hits branch September 22, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richard-ramos @status-im-auto @cammellos