Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAN Client #2656

Merged
merged 10 commits into from
Jun 20, 2022
Merged

LAN Client #2656

merged 10 commits into from
Jun 20, 2022

Conversation

Samyoul
Copy link
Member

@Samyoul Samyoul commented May 3, 2022 •
edited

What's Changed?

  • Added a new server.PairingClient
    • Required for programmatically connecting to a PairingServer
  • Added pairing handlers for PairingServer
    • send handler
    • receive handler
  • Added dynamic PairingServer handler loading
    • Prevents server from opening a receive handler when attempting to send
  • Added PayloadManager
    • Manages payloads for PairingClient and PairingServer
    • Handles payload encryption and decryption
    • Separates payload management concerns from clients and servers

Note for QA

No expected regressions, this implements new functionality that is entirely internal.

Dependant on #2653
Required for #2506

@Samyoul Samyoul self-assigned this May 3, 2022
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@status-im-auto
Copy link
Member

status-im-auto commented May 3, 2022 •
edited

Jenkins Builds

Click to see older builds (44)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 9e58134 #1 2022-05-03 14:55:46 ~1 min android 📄log
✔️ 9e58134 #1 2022-05-03 14:56:53 ~2 min linux 📦zip
✔️ 9e58134 #1 2022-05-03 14:59:09 ~4 min ios 📦zip
❌ 37b5ffa #2 2022-05-04 12:29:28 ~25 sec android 📄log
✔️ 37b5ffa #2 2022-05-04 12:32:06 ~3 min linux 📦zip
✔️ 37b5ffa #2 2022-05-04 12:32:14 ~3 min ios 📦zip
❌ 7194a9e #3 2022-05-10 09:36:26 ~1 min android 📄log
✔️ 7194a9e #3 2022-05-10 09:38:10 ~2 min linux 📦zip
✔️ 7194a9e #3 2022-05-10 09:40:38 ~5 min ios 📦zip
❌ b0b9f19 #4 2022-05-23 21:24:20 ~45 sec android 📄log
✔️ b0b9f19 #4 2022-05-23 21:26:32 ~2 min ios 📦zip
✔️ b0b9f19 #4 2022-05-23 21:31:58 ~8 min linux 📦zip
✔️ b7383e4 #5 2022-05-23 21:29:42 ~1 min ios 📦zip
✔️ b7383e4 #5 2022-05-23 21:37:07 ~9 min android 📦aar
✔️ c9de9a6 #6 2022-05-23 21:31:40 ~1 min ios 📦zip
✔️ c9de9a6 #5 2022-05-23 21:39:27 ~7 min linux 📦zip
✔️ c9de9a6 #6 2022-05-23 21:45:05 ~7 min android 📦aar
✔️ 5ff81af #6 2022-06-07 15:04:31 ~2 min linux 📦zip
✔️ 5ff81af #7 2022-06-07 15:06:08 ~3 min ios 📦zip
✔️ 5ff81af #7 2022-06-07 15:07:28 ~5 min android 📦aar
✔️ d059c22 #7 2022-06-10 15:37:09 ~4 min linux 📦zip
✔️ d059c22 #8 2022-06-10 15:38:13 ~5 min android 📦aar
✔️ d059c22 #8 2022-06-10 15:42:45 ~9 min ios 📦zip
✔️ 2b0071f #8 2022-06-10 23:12:09 ~1 min linux 📦zip
✔️ 2b0071f #9 2022-06-10 23:13:58 ~3 min ios 📦zip
✔️ 2b0071f #9 2022-06-10 23:14:01 ~3 min android 📦aar
✔️ 1048ea8 #9 2022-06-13 11:19:21 ~1 min linux 📦zip
✔️ 1048ea8 #10 2022-06-13 11:20:54 ~3 min ios 📦zip
✔️ 1048ea8 #10 2022-06-13 11:23:00 ~5 min android 📦aar
✔️ 91a0ac5 #11 2022-06-13 11:34:02 ~2 min ios 📦zip
✔️ 91a0ac5 #10 2022-06-13 11:34:03 ~2 min linux 📦zip
✔️ 91a0ac5 #11 2022-06-13 11:35:25 ~3 min android 📦aar
✔️ dc5c3b4 #11 2022-06-15 13:08:26 ~2 min linux 📦zip
✔️ dc5c3b4 #12 2022-06-15 13:08:31 ~2 min ios 📦zip
✔️ dc5c3b4 #12 2022-06-15 13:09:42 ~3 min android 📦aar
✔️ 1f435d1 #12 2022-06-15 13:54:12 ~1 min linux 📦zip
✔️ 1f435d1 #13 2022-06-15 13:55:43 ~3 min ios 📦zip
✔️ 1f435d1 #13 2022-06-15 13:56:06 ~3 min android 📦aar
✔️ 5dadd78 #13 2022-06-15 14:50:05 ~1 min linux 📦zip
✔️ 5dadd78 #14 2022-06-15 14:50:33 ~2 min ios 📦zip
✔️ 5dadd78 #14 2022-06-15 14:51:45 ~3 min android 📦aar
✔️ 5dadd78 #14 2022-06-15 15:38:11 ~1 min linux 📦zip
✔️ 5dadd78 #15 2022-06-15 15:38:42 ~2 min ios 📦zip
✔️ 5dadd78 #15 2022-06-15 15:39:45 ~3 min android 📦aar
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d9d8fb6 #15 2022-06-16 08:43:27 ~1 min linux 📦zip
✔️ d9d8fb6 #16 2022-06-16 08:44:33 ~2 min ios 📦zip
✔️ d9d8fb6 #16 2022-06-16 08:44:56 ~3 min android 📦aar
✔️ eb6ca2a #16 2022-06-20 14:15:58 ~1 min linux 📦zip
✔️ eb6ca2a #17 2022-06-20 14:16:48 ~2 min ios 📦zip
✔️ eb6ca2a #17 2022-06-20 14:17:58 ~3 min android 📦aar

@Samyoul Samyoul mentioned this pull request May 3, 2022
Merged
7 tasks
@Samyoul Samyoul force-pushed the feature/lan_connection_string branch from 7fd33f4 to aa7fa57 Compare May 3, 2022 16:02
@churik churik added this to Contributor in Client testing status-go May 11, 2022
@Samyoul Samyoul force-pushed the feature/lan_connection_string branch 2 times, most recently from 10803ec to 8710b4a Compare May 20, 2022 21:48
@Samyoul Samyoul force-pushed the feature/lan_client branch 3 times, most recently from b7383e4 to c9de9a6 Compare May 23, 2022 21:29
@Samyoul Samyoul force-pushed the feature/lan_connection_string branch 3 times, most recently from 3217b28 to b7391cc Compare June 7, 2022 14:51
@Samyoul Samyoul force-pushed the feature/lan_client branch 3 times, most recently from 1048ea8 to 91a0ac5 Compare June 13, 2022 11:31
@Samyoul Samyoul force-pushed the feature/lan_connection_string branch from b7391cc to 5b4a125 Compare June 15, 2022 13:02
@Samyoul Samyoul marked this pull request as ready for review June 15, 2022 14:07
@Samyoul Samyoul force-pushed the feature/lan_connection_string branch from 5b4a125 to 4acc6b7 Compare June 15, 2022 15:18
Base automatically changed from feature/lan_connection_string to develop June 15, 2022 15:36
@Samyoul Samyoul requested a review from bitgamma June 16, 2022 08:42
@Samyoul Samyoul moved this from Contributor to Ready for client testing in Client testing status-go Jun 16, 2022
@Samyoul Samyoul mentioned this pull request Jun 17, 2022
Closed
richard-ramos
richard-ramos approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

@pavloburykh pavloburykh self-assigned this Jun 20, 2022
@pavloburykh pavloburykh mentioned this pull request Jun 20, 2022
Closed
@pavloburykh pavloburykh added the Tested: mobile checked for regression on mobile client label Jun 20, 2022
@Samyoul Samyoul merged commit 62e212a into develop Jun 20, 2022
Client testing status-go automation moved this from Ready for client testing to DONE Jun 20, 2022
@Samyoul Samyoul deleted the feature/lan_client branch June 20, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@bitgamma bitgamma bitgamma approved these changes

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@cammellos cammellos Awaiting requested review from cammellos

Assignees

@Samyoul Samyoul

@pavloburykh pavloburykh

Labels
Tested: mobile checked for regression on mobile client
Projects
No open projects
Client testing status-go
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Samyoul @status-im-auto @richard-ramos @bitgamma @pavloburykh