Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: community tags #2708

Merged
merged 4 commits into from
Jun 24, 2022
Merged

feat: community tags #2708

merged 4 commits into from
Jun 24, 2022
+243 −85

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Jun 8, 2022 •
edited

Adds a new tags attribute to communities. The community json will return the tags as an array of objects:

[
   {"name": "the-tag-name", "emoji": "utf8 emoji"}, ...
]

@status-project-bot status-project-bot bot added this to Contributor in Client testing status-go Jun 8, 2022
@status-github-bot
Copy link

status-github-bot bot commented Jun 8, 2022 •
edited by elina2015

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@richard-ramos richard-ramos moved this from Contributor to Review in Client testing status-go Jun 8, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Jun 8, 2022 •
edited

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c85386b #1 2022-06-08 17:08:40 ~2 min linux 📦zip
✔️ c85386b #1 2022-06-08 17:10:56 ~4 min android 📦aar
✔️ c85386b #1 2022-06-08 17:11:17 ~4 min ios 📦zip
✔️ 2944e31 #2 2022-06-09 15:35:34 ~8 min ios 📦zip
✔️ 2944e31 #2 2022-06-09 15:38:32 ~11 min android 📦aar
✔️ 2944e31 #2 2022-06-09 15:40:18 ~13 min linux 📦zip
✔️ ba6902e #3 2022-06-14 19:58:25 ~2 min linux 📦zip
✔️ ba6902e #3 2022-06-14 19:58:25 ~2 min ios 📦zip
✔️ ba6902e #3 2022-06-14 20:00:44 ~4 min android 📦aar
✔️ 57b20fb #4 2022-06-17 11:40:48 ~2 min linux 📦zip
✔️ 57b20fb #4 2022-06-17 11:42:25 ~3 min android 📦aar
✔️ 57b20fb #4 2022-06-17 11:42:53 ~4 min ios 📦zip
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 35a65f3 #5 2022-06-21 18:34:07 ~2 min linux 📦zip
✔️ 35a65f3 #5 2022-06-21 18:34:16 ~2 min ios 📦zip
✔️ 35a65f3 #5 2022-06-21 18:36:36 ~4 min android 📦aar
✔️ 36c78b3 #6 2022-06-24 12:36:29 ~2 min ios 📦zip
✔️ 36c78b3 #6 2022-06-24 12:36:31 ~2 min linux 📦zip
✔️ 36c78b3 #6 2022-06-24 12:38:55 ~4 min android 📦aar

osmaczko
osmaczko approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MishkaRogachev
MishkaRogachev approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works!

@iurimatias iurimatias mentioned this pull request Jun 15, 2022
Merged
@richard-ramos richard-ramos moved this from Review to Ready for client testing in Client testing status-go Jun 17, 2022
@churik churik self-assigned this Jun 17, 2022
@churik churik mentioned this pull request Jun 17, 2022
Closed
@churik churik added the Tested: mobile checked for regression on mobile client label Jun 17, 2022
@iurimatias iurimatias added the Tested: desktop checked for regression on desktop client label Jun 21, 2022
@elina2015 elina2015 moved this from Ready for client testing to Merge in Client testing status-go Jun 22, 2022
@richard-ramos richard-ramos merged commit 2873e65 into develop Jun 24, 2022
Client testing status-go automation moved this from Merge to DONE Jun 24, 2022
@richard-ramos richard-ramos deleted the feat/community-tags branch June 24, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishkaRogachev MishkaRogachev MishkaRogachev approved these changes

@osmaczko osmaczko osmaczko approved these changes

Assignees

@churik churik

Labels
Tested: desktop checked for regression on desktop client Tested: mobile checked for regression on mobile client
Projects
No open projects
Client testing status-go
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@richard-ramos @status-im-auto @MishkaRogachev @osmaczko @iurimatias @churik