Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
I've deactivated syncing of sticker packs because the current implementation introduces a regression on deletion of sticker packs.
Steps to reproduce
device 1
anddevice 2
sticker pack 1
todevice 1
device 2
receivedsticker pack 1
device 1
deletessticker pack 1
device 2
addssticker pack 2
device 2
receives late setting state ofdevice 1
and does not removesticker pack 1
because clock is older than whensticker pack 2
was addeddevice 1
receives update includingsticker pack 1
and2
device 1
hassticker pack 1
again andsticker pack 2
This issue can be fixed but requires more work to be done on #2717 Currently functionality in 2717 has merge only functionality and doesn't handle deletion either. Deletion is a bit trickier than merge only, can be fixed with a
deletedAt
field in theStickerPack
struct, but will require coordination with desktop UI and mobile UI.cc @churik and @audriu
Notes For QA:
This functionality removes syncing of sticker packs, so no sticker packs should be synced in testing