Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing display name when requesting to join a community #2725

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: missing display name when requesting to join a community #2725

merged 1 commit into from
Jun 22, 2022

Conversation

richard-ramos
Copy link
Member

@status-github-bot
Copy link

status-github-bot bot commented Jun 22, 2022 •
edited by richard-ramos

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@status-im-auto
Copy link
Member

status-im-auto commented Jun 22, 2022 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dd23d16 #1 2022-06-22 16:28:02 ~2 min linux 📦zip
✔️ dd23d16 #1 2022-06-22 16:29:02 ~3 min ios 📦zip
✔️ dd23d16 #1 2022-06-22 16:30:26 ~4 min android 📦aar

@richard-ramos richard-ramos merged commit 31feea9 into develop Jun 22, 2022
@richard-ramos richard-ramos deleted the fix/display_name_request_join branch June 22, 2022 18:02
Client testing status-go automation moved this from Contributor to DONE Jun 22, 2022
@richard-ramos richard-ramos moved this from DONE to Ready for client testing in Client testing status-go Jun 22, 2022
@richard-ramos
Copy link
Member Author

I merged it by mistake. It shouldnt cause problems but just in case, I moved it back to "Client testing". If any issue is found I'll revert this change!

@churik churik moved this from Ready for client testing to DONE in Client testing status-go Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville approved these changes

@iurimatias iurimatias Awaiting requested review from iurimatias

@alaibe alaibe Awaiting requested review from alaibe

@stefandunca stefandunca Awaiting requested review from stefandunca

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Client testing status-go
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richard-ramos @status-im-auto @jrainville