Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goerli: contracts for testnet #2741

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Goerli: contracts for testnet #2741

merged 1 commit into from
Jul 20, 2022

Conversation

churik
Copy link
Member

@churik churik commented Jul 5, 2022 •
edited

Added contracts, required for Goerli testnet: ENS, MiniMeToken, StickerMarket, StickerPacks

Corresponding PR in status-react: status-im/status-mobile#13660

PR won't affect status-desktop client, so testing can be skipped.

@status-project-bot status-project-bot bot added this to Contributor in Client testing status-go Jul 5, 2022
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@status-im-auto
Copy link
Member

status-im-auto commented Jul 5, 2022 •
edited

Jenkins Builds

Click to see older builds (30)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 9f7f163 #1 2022-07-05 15:14:02 ~4 min ios 📄log
❌ 9f7f163 #1 2022-07-05 15:14:05 ~4 min android 📄log
❌ 9f7f163 #1 2022-07-05 15:15:14 ~5 min linux 📄log
❌ bf98a30 #2 2022-07-05 15:29:55 ~29 sec ios 📄log
❌ bf98a30 #2 2022-07-05 15:30:13 ~46 sec linux 📄log
❌ bf98a30 #2 2022-07-05 15:31:10 ~1 min android 📄log
✔️ a30df71 #3 2022-07-05 15:33:49 ~1 min linux 📦zip
✔️ a30df71 #3 2022-07-05 15:34:37 ~2 min ios 📦zip
✔️ a30df71 #3 2022-07-05 15:35:31 ~3 min android 📦aar
✔️ 84849fb #4 2022-07-13 08:58:24 ~3 min linux 📦zip
✔️ 84849fb #4 2022-07-13 08:59:22 ~4 min android 📦aar
✔️ 84849fb #4 2022-07-13 08:59:57 ~5 min ios 📦zip
✔️ 7e242ef #5 2022-07-13 08:59:57 ~1 min linux 📦zip
✔️ 7e242ef #5 2022-07-13 09:02:02 ~2 min ios 📦zip
✔️ 7e242ef #5 2022-07-13 09:03:04 ~3 min android 📦aar
✔️ 307dcaa #6 2022-07-14 08:53:23 ~2 min linux 📦zip
✔️ 307dcaa #6 2022-07-14 08:54:43 ~3 min ios 📦zip
✔️ 307dcaa #6 2022-07-14 08:54:56 ~3 min android 📦aar
✔️ e9cf09d #7 2022-07-14 08:56:02 ~1 min linux 📦zip
✔️ e9cf09d #7 2022-07-14 08:57:14 ~2 min ios 📦zip
✔️ e9cf09d #7 2022-07-14 08:57:56 ~2 min android 📦aar
✔️ 7fedc97 #8 2022-07-19 12:29:35 ~2 min linux 📦zip
✔️ 7fedc97 #8 2022-07-19 12:31:41 ~4 min ios 📦zip
✔️ 7fedc97 #8 2022-07-19 12:32:28 ~5 min android 📦aar
✔️ d8d3547 #9 2022-07-20 05:38:42 ~2 min linux 📦zip
✔️ d8d3547 #9 2022-07-20 05:38:52 ~2 min ios 📦zip
✔️ d8d3547 #9 2022-07-20 05:40:01 ~3 min android 📦aar
✔️ af4b077 #10 2022-07-20 11:32:07 ~1 min linux 📦zip
✔️ af4b077 #10 2022-07-20 11:33:26 ~3 min android 📦aar
✔️ af4b077 #10 2022-07-20 11:35:01 ~4 min ios 📦zip
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5787aad #11 2022-07-20 12:06:37 ~1 min linux 📦zip
✔️ 5787aad #11 2022-07-20 12:07:01 ~2 min ios 📦zip
✔️ 5787aad #11 2022-07-20 12:07:57 ~3 min android 📦aar
✔️ 3cd92fd #12 2022-07-20 12:19:14 ~3 min linux 📦zip
✔️ 3cd92fd #12 2022-07-20 12:19:17 ~3 min android 📦aar
✔️ 3cd92fd #12 2022-07-20 12:24:45 ~9 min ios 📦zip

@churik churik force-pushed the goerli-transition branch 2 times, most recently from 84849fb to 7e242ef Compare July 13, 2022 08:55
This was referenced Jul 13, 2022
Closed
Merged
@churik churik force-pushed the goerli-transition branch 2 times, most recently from e9cf09d to 7fedc97 Compare July 19, 2022 12:26
@churik churik changed the title [WIP] goerli: stickermarket Goerli: contracts for testnet Jul 20, 2022
@churik churik added the Tested: mobile checked for regression on mobile client label Jul 20, 2022
@churik churik marked this pull request as ready for review July 20, 2022 05:40
@churik churik moved this from Contributor to Review in Client testing status-go Jul 20, 2022
@churik churik self-assigned this Jul 20, 2022
@churik churik requested a review from Samyoul July 20, 2022 05:45
@churik
Copy link
Member Author

churik commented Jul 20, 2022

@Samyoul can you please help me with lint? not sure what happened there and how my changes may cause this

@Samyoul
Copy link
Member

Samyoul commented Jul 20, 2022

@churik I've found the issue, it is the most ridiculous linting issue I've ever seen. Line 1426 should be:

  },

The fail is because the linter wants consistent indentation chars and that line has a mix of spaces and tabs, I think it expects <TAB><TAB>},

@churik churik force-pushed the goerli-transition branch 2 times, most recently from af4b077 to 5787aad Compare July 20, 2022 12:04
@churik churik merged commit 3cd92fd into develop Jul 20, 2022
Client testing status-go automation moved this from Review to DONE Jul 20, 2022
@churik churik deleted the goerli-transition branch July 20, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samyoul Samyoul Samyoul approved these changes

Assignees

@churik churik

Labels
Tested: mobile checked for regression on mobile client
Projects
No open projects
Client testing status-go
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@churik @status-im-auto @Samyoul