feat: share image/username on separate topic on a community #2745

osmaczko · 2022-07-08T10:36:11Z

publishContactCode now also publishes on joined communities separate topic
publishIdentityImage is now triggered each time user joins a new community, this is to ensure other community members got updated with user details immediately

closes: #2707

status-github-bot · 2022-07-08T10:36:28Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?
Have you tested changes with mobile?
Have you tested changes with desktop?

status-im-auto · 2022-07-08T10:39:42Z

Jenkins Builds

Click to see older builds (3)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`06211d1`	#1	2022-07-08 10:39:42	~3 min	`linux`	📦`zip`
✔️	`06211d1`	#1	2022-07-08 10:41:16	~4 min	`ios`	📦`zip`
✔️	`06211d1`	#1	2022-07-08 10:42:53	~6 min	`android`	📦`aar`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`02d5068`	#2	2022-07-13 09:56:36	~2 min	`linux`	📦`zip`
✔️	`02d5068`	#2	2022-07-13 09:58:27	~4 min	`android`	📦`aar`
✔️	`02d5068`	#2	2022-07-13 09:59:17	~5 min	`ios`	📦`zip`

✔️	`3ac5887`	#3	2022-07-18 12:20:20	~2 min	`linux`	📦`zip`
✔️	`3ac5887`	#3	2022-07-18 12:20:53	~3 min	`ios`	📦`zip`
✔️	`3ac5887`	#3	2022-07-18 12:22:33	~4 min	`android`	📦`aar`

0x-r4bbit

Changes LGTM.
Can we have 1-2 tests for this please?

osmaczko · 2022-07-13T09:56:15Z

Changes LGTM. Can we have 1-2 tests for this please?

@PascalPrecht tests added, please take a look: https://github.com/status-im/status-go/pull/2745/files#diff-d4f4b1d3dcfd1f9dda7f6d7a397650c30b499042a7770a1df9a6fe80d61f04fe

cammellos

Great PR!

cammellos · 2022-07-13T10:01:28Z

protocol/communities_messenger_test.go

+		s.Require().NotNil(response)
+	}
+
+	patryk := s.newMessenger()


Bob's going to be jealous 😎

osmaczko · 2022-07-13T10:24:41Z

waiting for tests: status-im/status-mobile#13661

0x-r4bbit · 2022-07-14T08:09:06Z

Nice work @osmaczko

pavloburykh · 2022-07-14T08:49:54Z

@osmaczko Thanx for the PR! If it is ready for QA, could you please move it to Ready for client testing column, in order it be taken into test by both desktop and mobile QA teams? Thank you!

osmaczko · 2022-07-14T09:17:47Z

@osmaczko Thanx for the PR! If it is ready for QA, could you please move it to Ready for client testing column, in order it be taken into test by both desktop and QA team? Thank you!

Thanks. Ofc, done 👍

pavloburykh · 2022-07-14T15:54:03Z

@osmaczko thank you for the PR.

Tested on mobile and got a question about ENS name updating in community channel:

User's ENS name is updated for other community users only after ENS user posts some message in channel. Is it an expected behaviour?

Steps:

Create a new community
Create a new User 1
Join community via newly created User 1
Join community via User 2 who has couple of ENS names connected
Try to change User's 2 ENS name (without posting new messages in channel after update) and see if User 1 can see updated ENS.

Actual result: User 1 doesn't see User's 2 updated ENS until User 2 posts some message in community channel.

Expected result: ??? User 1 sees User's 2 updated ENS name, right after it has been updated.

PS: sorry, not sure if this problem is related to current PR.

ENS_update_community.mp4

osmaczko · 2022-07-18T11:03:14Z

@pavloburykh thanks for testing.

It seems propagating ENS name with contact identity is not yet implemented (FYI @cammellos)

Actual result: User 1 doesn't see User's 2 updated ENS until User 2 posts some message in community channel.

I believe the same issue happens in any other kind of chat (public, group, 1on1), could you please check?

Expected result: ??? User 1 sees User's 2 updated ENS name, right after it has been updated.

Yes, I would expect so.

IMO the issue is not related to this PR and should be solved separately. Since on mobile, display names are not implemented yet (:question:), I'm attaching a video where display names are propagated to community members as expected:

community-rename-2022-07-18_12.38.43.mp4

Changing user images also works as expected:

community-avatar-2022-07-18_13.07.02.mp4

pavloburykh · 2022-07-18T12:01:33Z

@osmaczko thank you! You're right, this issue is not related to current PR. Therefore, currently there are no issues from mobile side. Waiting for desktop QA team to test the PR, after that it will be ready for merge.

closes: #2707

test only commit status-im/status-go#2745

anastasiyaig · 2022-07-20T08:00:26Z

@osmaczko 1 question i want to clarify: as user2 , having custom picture, i joined community and this user's picture is not displayed in members list of community, or Online users section:

I created status-im/status-desktop#6530 to test the commit in go, double checked - it points to correct version

anastasiyaig · 2022-07-20T08:21:42Z

okay , the issue is a separate one related to settings

status-project-bot bot added this to Contributor in Client testing status-go Jul 8, 2022

osmaczko requested review from 0x-r4bbit, cammellos and richard-ramos July 8, 2022 10:36

0x-r4bbit approved these changes Jul 8, 2022

View reviewed changes

richard-ramos approved these changes Jul 8, 2022

View reviewed changes

osmaczko force-pushed the feat/2702/community-share-user-separate-topic branch from 06211d1 to 02d5068 Compare July 13, 2022 09:53

cammellos approved these changes Jul 13, 2022

View reviewed changes

osmaczko mentioned this pull request Jul 13, 2022

status-go: share image/username on separate topic on a community status-im/status-mobile#13661

Closed

osmaczko moved this from Contributor to Ready for client testing in Client testing status-go Jul 14, 2022

pavloburykh self-assigned this Jul 15, 2022

pavloburykh added the mobile: tested-issues label Jul 15, 2022

pavloburykh moved this from Ready for client testing to Contributor in Client testing status-go Jul 15, 2022

pavloburykh added Tested: mobile checked for regression on mobile client and removed mobile: tested-issues labels Jul 18, 2022

pavloburykh moved this from Contributor to Ready for client testing in Client testing status-go Jul 18, 2022

feat: share image/username on separate topic on a community

3ac5887

closes: #2707

osmaczko force-pushed the feat/2702/community-share-user-separate-topic branch from 02d5068 to 3ac5887 Compare July 18, 2022 12:17

osmaczko added a commit to status-im/status-desktop that referenced this pull request Jul 18, 2022

status-go: share image/username on separate topic on a community

9d4c04a

test only commit status-im/status-go#2745

osmaczko mentioned this pull request Jul 18, 2022

status-go: share image/username on separate topic on a community status-im/status-desktop#6505

Closed

This was referenced Jul 19, 2022

Update status-go status-im/status-desktop#6528

Closed

Update status-go status-im/status-desktop#6530

Closed

anastasiyaig added the Tested: desktop checked for regression on desktop client label Jul 20, 2022

anastasiyaig moved this from Ready for client testing to Merge in Client testing status-go Jul 20, 2022

osmaczko merged commit e5e0740 into develop Jul 20, 2022

Client testing status-go automation moved this from Merge to DONE Jul 20, 2022

osmaczko deleted the feat/2702/community-share-user-separate-topic branch July 20, 2022 08:35

osmaczko mentioned this pull request Oct 25, 2023

Publish image and contact code when joining community #4011

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: share image/username on separate topic on a community #2745

feat: share image/username on separate topic on a community #2745

osmaczko commented Jul 8, 2022

status-github-bot bot commented Jul 8, 2022 •

edited by anastasiyaig

status-im-auto commented Jul 8, 2022 •

edited

0x-r4bbit left a comment

osmaczko commented Jul 13, 2022

cammellos left a comment

cammellos Jul 13, 2022

osmaczko commented Jul 13, 2022 •

edited

0x-r4bbit commented Jul 14, 2022

pavloburykh commented Jul 14, 2022 •

edited

osmaczko commented Jul 14, 2022

pavloburykh commented Jul 14, 2022

osmaczko commented Jul 18, 2022 •

edited

pavloburykh commented Jul 18, 2022

anastasiyaig commented Jul 20, 2022 •

edited

anastasiyaig commented Jul 20, 2022

feat: share image/username on separate topic on a community #2745

feat: share image/username on separate topic on a community #2745

Conversation

osmaczko commented Jul 8, 2022

status-github-bot bot commented Jul 8, 2022 • edited by anastasiyaig

Pull Request Checklist

status-im-auto commented Jul 8, 2022 • edited

Jenkins Builds

0x-r4bbit left a comment

Choose a reason for hiding this comment

osmaczko commented Jul 13, 2022

cammellos left a comment

Choose a reason for hiding this comment

cammellos Jul 13, 2022

Choose a reason for hiding this comment

osmaczko commented Jul 13, 2022 • edited

0x-r4bbit commented Jul 14, 2022

pavloburykh commented Jul 14, 2022 • edited

osmaczko commented Jul 14, 2022

pavloburykh commented Jul 14, 2022

User's ENS name is updated for other community users only after ENS user posts some message in channel. Is it an expected behaviour?

osmaczko commented Jul 18, 2022 • edited

pavloburykh commented Jul 18, 2022

anastasiyaig commented Jul 20, 2022 • edited

anastasiyaig commented Jul 20, 2022

status-github-bot bot commented Jul 8, 2022 •

edited by anastasiyaig

status-im-auto commented Jul 8, 2022 •

edited

osmaczko commented Jul 13, 2022 •

edited

pavloburykh commented Jul 14, 2022 •

edited

osmaczko commented Jul 18, 2022 •

edited

anastasiyaig commented Jul 20, 2022 •

edited