Images Album #3021
Merged
Images Album #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (33)
|
stefandunca
approved these changes
Dec 14, 2022
cammellos
approved these changes
Dec 14, 2022
|
@OmarBasem we have users reporting: Are we show this works with databases that have messages which don't have an |
|
I think we need to ensure that this works with existing databases that don't have an |
0x-r4bbit
added a commit
that referenced
this pull request
Dec 14, 2022
Otherwise databases with existing messages that don't have an `album_id` will run into and `converting NULL to string is unsupported` error. See: #3021 (comment)
|
Created #3023 accordingly |
0x-r4bbit
added a commit
that referenced
this pull request
Dec 16, 2022
Otherwise databases with existing messages that don't have an `album_id` will run into and `converting NULL to string is unsupported` error. See: #3021 (comment)
0x-r4bbit
added a commit
that referenced
this pull request
Dec 16, 2022
Otherwise databases with existing messages that don't have an `album_id` will run into and `converting NULL to string is unsupported` error. See: #3021 (comment)
0x-r4bbit
added a commit
that referenced
this pull request
Dec 16, 2022
Otherwise databases with existing messages that don't have an `album_id` will run into and `converting NULL to string is unsupported` error. See: #3021 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
AlbumIDfield to messages in order to be able to group images sent together like a collage.