Handle 'web.accounts' call in Jail properly #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
suggested changes
Oct 6, 2017
| @@ -51,6 +52,11 @@ func registerHandlers(jail *Jail, cell common.JailCell, chatID string) error { | |||
| return err | |||
| } | |||
|
|
|||
| // register accounts handler | |||
| if err = registerHandler("accounts", makeAccountsHandler(jail, cell)); err != nil { | |||
There was a problem hiding this comment.
I don't get it. In StatusBackend we have:
rpcClient.RegisterHandler("eth_accounts", m.accountManager.AccountsRPCHandler())
rpcClient.RegisterHandler("eth_sendTransaction", m.txQueueManager.SendTransactionRPCHandler)When web3.eth.accounts is called, it should do an RPC call and go through the already registered handler.
|
This solution seems to be incorrect and doesn't fix bug it mentions. It's not a routing issue, rather result conversion issue when converting data from otto VM. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug (#384) with incorrect routing of
web3.eth.account()call in Jail. Bug was introduced in #351 wheneth_accounthandler was implemented and properly handled in RPC client, but it's jail's counterpart was forgotten.