Remove go.rice in favour of go generate #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
influx6
approved these changes
Nov 2, 2017
divan
reviewed
Nov 2, 2017
| rice embed-go | ||
| generate: dist-fetch/bundle.js | ||
| go generate . | ||
| gofmt -s -w dist_fetch.go |
There was a problem hiding this comment.
Not sure simplify option (-s) has any benefit here for autogenerated code.
There was a problem hiding this comment.
Might not but I don't see any negative impact having -s.
divan
reviewed
Nov 2, 2017
| dist-fetch.rice-box.go: dist-fetch/bundle.js | ||
| rice embed-go | ||
| generate: dist-fetch/bundle.js | ||
| go generate . |
There was a problem hiding this comment.
I don't see any //go:generate comments in code. Did you run go-bindata manually to produce dist-fetch.go?
There was a problem hiding this comment.
divan
approved these changes
Nov 3, 2017
JekaMas
approved these changes
Nov 3, 2017
tiabc
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fetch.go was the only consumer of go.rice, it could be safely removed in favour of go-bindata and go generate.
Motivation to do that was the fact that
go.ricethrows panic in iOS when compiled with gomobile.