Bug: Fix view&post token-permitted channel input not locked #5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
jrainville
reviewed
Apr 8, 2024
Yes, here is a video recording Screencast.from.2024-04-08.07.59.35.AM.webm |
kounkou
force-pushed
the
fix-view-post-token-permitted-channel
branch
2 times, most recently
from
3c52df5
to
caf512a
Compare
In the video, we can see that it didn't work as intended. The Account with 0.15 ETH was unselected, and still, all the channel were marked a |
Oh right, I misread your sentence. I think while preparing the code for testing I inadvertently changed something, let me double check. This flow should already work. Screencast.from.2024-04-08.02.28.18.PM.webm |
kounkou
force-pushed
the
fix-view-post-token-permitted-channel
branch
from
caf512a
to
c126eb3
Compare
jrainville
approved these changes
Apr 9, 2024
MishkaRogachev
approved these changes
Apr 9, 2024
kounkou
force-pushed
the
fix-view-post-token-permitted-channel
branch
2 times, most recently
from
ce29cce
to
e532b61
Compare
We are now able to lock consistently the channel if we do not have permission to view&post. This PR fixes status-im/status-desktop#14117
kounkou
force-pushed
the
fix-view-post-token-permitted-channel
branch
from
e532b61
to
21cccbe
Compare
kounkou
added a commit
that referenced
this pull request
Apr 10, 2024
We are now able to lock consistently the channel if we do not have permission to view&post. This PR fixes status-im/status-desktop#14117
kounkou
added a commit
that referenced
this pull request
Apr 10, 2024
We are now able to lock consistently the channel if we do not have permission to view&post. This PR fixes status-im/status-desktop#14117
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In previous version of status-go, we failed to compute the permission for communities with token permitted channels. This caused the UI to display the wrong UI when displaying the channel UI. Indeed, the user was enable to view the channel and couldn't send messages.
In this PR, we are now able to lock consistently the channel if we do not have permission to view&post. This PR fixes #14117
The change consists in adding a retrieval of the Revealed accounts for cases when the addresses are not shared, and where the purpose isn't to have all accounts considered for the calculation of permissions on channel.
Testing
Multiple tests already cover the functions
CheckAllChannelsPermissionsandCheckChannelPermissions, making sure all tests are passed. If any strong opinion on the testing side, I can allocate a bit more time.I have also checked the flows :
-[x] Restore write when channel is unlocked
-[x] Set the channel permissions at boot
-[x] Detect changes when user
-[x] edit permissions
-[x] create permissions
-[x] delete permissions
Demo
Screencast.from.2024-04-08.12.18.14.AM.webm