fix_: mitigate permission stuck in pending state #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (83)
|
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
2 times, most recently
from
67327a6
to
cd10710
Compare
kounkou
commented
Apr 19, 2024
osmaczko
reviewed
Apr 19, 2024
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
9 times, most recently
from
6fe326b
to
212eebc
Compare
|
Hi there, |
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
from
212eebc
to
04dd0f8
Compare
mprakhov
reviewed
Apr 30, 2024
mprakhov
reviewed
Apr 30, 2024
mprakhov
reviewed
Apr 30, 2024
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
3 times, most recently
from
d9170f0
to
3dde1e8
Compare
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
from
3dde1e8
to
295db89
Compare
mprakhov
reviewed
May 9, 2024
mprakhov
approved these changes
May 9, 2024
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
3 times, most recently
from
7e72ab1
to
51cb49e
Compare
This PR mitigates permission stuck in pending state upon making device a control node. It fixes [#14023](status-im/status-desktop#14023)
kounkou
force-pushed
the
fix-activate-permissions-upon-making-device-controlnode
branch
from
51cb49e
to
7d8f819
Compare
MishkaRogachev
approved these changes
May 10, 2024
| @@ -71,6 +71,18 @@ const ( | |||
| maxChunkSizeBytes = 1500000 | |||
| ) | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
Kudos on keeping all the errors in one place!
kounkou
deleted the
fix-activate-permissions-upon-making-device-controlnode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mitigates permission stuck in pending state upon making device a control node. It fixes #14023 by applying events and publishing community events once the device is promoted to control node.
System Design
The main design decision for this issue is that promoteSelfToControlNode is inhibited when the community doesn't have a minted Owner token. From the UI perspective, the action is disabled similar to when the user is an
adminuser. And from the backend perspective, the action is also rejected with missing owner token code.