-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add l1 transaction fee to community token contracts operations #5071
Conversation
Jenkins BuildsClick to see older builds (16)
|
return res | ||
} | ||
|
||
func (s *Service) deployOwnerTokenEstimate(ctx context.Context, chainID uint64, fromAddress string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most important changes are in this file. For every operation:
- compute gas units,
- get suggested fees,
- compute l1 fee.
5d139ac
to
2e94b07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was like "Man this PR is very big for what I thought it would be. Also some of the code feels similar to what I've seen before"
Then I saw that you were based on top of the transaction refactor, but there is a conflict right now, so it doesn't show the diff correctly, so I reviewed only the second commit
2e94b07
to
565f8d1
Compare
565f8d1
to
98b7a47
Compare
f06b030
to
87b89e0
Compare
Move estimation funtions to a estimations.go Compute gas, suggested fees and l1 fee in one status-go call Issue #14166
87b89e0
to
c39d1e8
Compare
Move estimation funtions to a estimations.go
Compute gas, suggested fees and l1 fee in one status-go call
Issue #14166