refactor_: set default node config values for frontend when doing local pair sync #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
This was referenced Apr 22, 2024
Merged
qfrank
force-pushed
the
fix/local_pairing_network_id
branch
2 times, most recently
from
f4f986d
to
5532ec5
Compare
qfrank
changed the title
Samyoul
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Oh, I totally forgot that we also pass nodeConfig from client in local pairing.
Maybe instead of this quick fix it's better to remove nodeConfig parameter from local pairing API and take the default config from status-go?
There's intention to remove direct using of nodeConfig by client apps.
This is already done for create/restore accounts on mobile. Desktop is on the way: status-im/status-desktop#14139
I planned to merge this small PR first, and do another one to remove @igor-sirotin |
qfrank
force-pushed
the
fix/local_pairing_network_id
branch
from
5532ec5
to
72c7bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because mobile won't pass NetworkID/UpstreamConfig/Datadir anymore when doing local pair sync, backend will set the default value instead.