Limit number of members in a community and number of pending requests #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
igor-sirotin
approved these changes
Apr 30, 2024
| @@ -2816,6 +2833,15 @@ func (m *Manager) HandleCommunityRequestToJoin(signer *ecdsa.PublicKey, receiver | |||
| } | |||
| } | |||
|
|
|||
| // Check if we reached the limit, if we did, change the community setting to be On Request | |||
| if community.AutoAccept() && community.MembersCount() >= maxNbMembers { | |||
There was a problem hiding this comment.
Do we want to restore PermissionAccess to original value when the there's less nu members again? 🤔
There was a problem hiding this comment.
That would be a good idea, but I'll keep it simple for now. In theory, if we do reach the limit and the app still behaves nicely, we would create a new build with a higher limit first.
MishkaRogachev
approved these changes
Apr 30, 2024
jrainville
force-pushed
the
feat/limit-nb-members
branch
from
9fe7e64
to
97f4714
Compare
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-desktop#14532
Once the limit of members is reached, the community switches to On Request (manual approval).
Also, I put a limit on the number of pending requests in case the spam gets crazy.
I added a test that I ran a hundred times (I can run it more if we want, but it's long 💀 )