chore_: Remove old status community from the database #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (30)
|
ilmotta
reviewed
May 6, 2024
| @@ -0,0 +1,3 @@ | |||
| DELETE FROM communities_communities WHERE id = X'039b2da47552aa117a96ea8f1d4d108ba66637c7517a3c94a57b99dbb8a002eda2'; | |||
| DELETE FROM communities_events WHERE id = X'039b2da47552aa117a96ea8f1d4d108ba66637c7517a3c94a57b99dbb8a002eda2'; | |||
| DELETE FROM communities_shards WHERE community_id = X'039b2da47552aa117a96ea8f1d4d108ba66637c7517a3c94a57b99dbb8a002eda2'; | |||
There was a problem hiding this comment.
@Parveshdhull I'm not sure about the validity of my feedback, but to be correct, shouldn't the migration also delete records in the following tables? They all contain a column named community_id.
activity_center_notificationsapplied_community_eventscollapsed_community_categoriescommunities_check_channel_permission_responsescommunities_control_nodecommunities_permission_token_criteria_resultscommunities_requests_to_leavecommunity_grantscommunity_tokenscurated_communitiesencrypted_community_description_cacheencrypted_community_description_id_and_clockencrypted_community_description_missing_keysprofile_showcase_communities_contactsprofile_showcase_communities_preferences
There was a problem hiding this comment.
Hi @ilmotta, Thank you very much for your valuable feedback and sharing these tables.
Probably we should also delete from these table too, but I am not sure as DeleteCommunity function only deletes from above three 🤔
status-go/protocol/communities/persistence.go
Line 219 in 9c2c638
Maybe @cammellos will have more info.
There was a problem hiding this comment.
Maybe @cammellos will have more info.
Confirmed. Removing from these 3 tables should be enough.
There was a problem hiding this comment.
Great! Thanks for taking the time to check @Parveshdhull
cammellos
approved these changes
May 8, 2024
Parveshdhull
force-pushed
the
chore/remove-status-communityf
branch
from
da94812
to
0a8d7c9
Compare
ilmotta
approved these changes
May 8, 2024
Parveshdhull
force-pushed
the
chore/remove-status-communityf
branch
from
0a8d7c9
to
e50deb2
Compare
|
closing the PR as removal of status old community is breaking the tests and needs some workaround |
|
reopen this PR, I'll continue work based on this branch |
qfrank
force-pushed
the
chore/remove-status-communityf
branch
from
835c683
to
551a818
Compare
qfrank
force-pushed
the
chore/remove-status-communityf
branch
2 times, most recently
from
6ca2ac3
to
01c161a
Compare
qfrank
force-pushed
the
chore/remove-status-communityf
branch
from
01c161a
to
eb7876f
Compare
osmaczko
approved these changes
May 13, 2024
MishkaRogachev
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes status-im/status-mobile#19868
required for status-im/status-mobile#19905
status: ready