unit tests for utils functions

status-im · Apr 25, 2024 · 6e886c8 · 6e886c8
1 parent 131b574
commit 6e886c8
Show file tree

Hide file tree

Showing 6 changed files with 112 additions and 96 deletions.
diff --git a/src/status_im/contexts/wallet/common/utils/send.cljs b/src/status_im/contexts/wallet/common/utils/send.cljs
diff --git a/src/status_im/contexts/wallet/common/utils/send_test.cljs b/src/status_im/contexts/wallet/common/utils/send_test.cljs
diff --git a/src/status_im/contexts/wallet/send/utils.cljs b/src/status_im/contexts/wallet/send/utils.cljs
@@ -126,11 +126,11 @@
       (conj {:type :add}))))
 
 (defn loading-network-amounts
-  [affordable-networks disabled-chain-ids receiver-networks to?]
+  [valid-networks disabled-chain-ids receiver-networks to?]
   (let [disabled-set            (set disabled-chain-ids)
         receiver-networks-set   (set receiver-networks)
         receiver-networks-count (count receiver-networks)
-        valid-networks          (concat affordable-networks disabled-chain-ids)]
+        valid-networks          (concat valid-networks disabled-chain-ids)]
     (cond-> (->> valid-networks
                  (map (fn [k]
                         (cond-> {:chain-id k

diff --git a/src/status_im/contexts/wallet/send/utils_test.cljs b/src/status_im/contexts/wallet/send/utils_test.cljs
@@ -1,6 +1,7 @@
 (ns status-im.contexts.wallet.send.utils-test
   (:require [cljs.test :refer [deftest is testing]]
             [status-im.contexts.wallet.send.utils :as utils]
+            [utils.map :as map]
             [utils.money :as money]))
 
 (deftest test-amount-in-hex
@@ -203,3 +204,92 @@
       (is (= expected
              (utils/token-valid-networks {:balances-per-chain balances-per-chain
                                           :disabled-chain-ids disabled-chain-ids}))))))
+
+(deftest test-clean-network-amounts
+  (testing "Correctly resets loading network amounts to zero and changes type to default"
+    (let [network-amounts [{:chain-id "1" :total-amount (money/bignumber "100") :type :loading}
+                           {:chain-id "2" :total-amount (money/bignumber "200") :type :default}]
+          expected        [{:chain-id "1" :total-amount (money/bignumber "0") :type :default}
+                           {:chain-id "2" :total-amount (money/bignumber "200") :type :default}]]
+      (is (map/deep-compare-maps expected (utils/clean-network-amounts network-amounts)))))
+
+  (testing "Leaves non-loading types unchanged"
+    (let [network-amounts [{:chain-id "1" :total-amount (money/bignumber "100") :type :default}
+                           {:chain-id "2" :total-amount (money/bignumber "0") :type :disabled}]
+          expected        [{:chain-id "1" :total-amount (money/bignumber "100") :type :default}
+                           {:chain-id "2" :total-amount (money/bignumber "0") :type :disabled}]]
+      (is (map/deep-compare-maps expected (utils/clean-network-amounts network-amounts)))))
+
+  (testing "Processes an empty list without error"
+    (let [network-amounts []
+          expected        []]
+      (is (map/deep-compare-maps expected (utils/clean-network-amounts network-amounts)))))
+
+  (testing "Applies transformations to multiple loading entries"
+    (let [network-amounts [{:chain-id "1" :total-amount (money/bignumber "100") :type :loading}
+                           {:chain-id "2" :total-amount (money/bignumber "200") :type :loading}]
+          expected        [{:chain-id "1" :total-amount (money/bignumber "0") :type :default}
+                           {:chain-id "2" :total-amount (money/bignumber "0") :type :default}]]
+      (is (map/deep-compare-maps expected (utils/clean-network-amounts network-amounts)))))
+
+  (testing "Mix of loading and non-loading types"
+    (let [network-amounts [{:chain-id "1" :total-amount (money/bignumber "100") :type :loading}
+                           {:chain-id "2" :total-amount (money/bignumber "200") :type :default}
+                           {:chain-id "3" :total-amount (money/bignumber "300") :type :loading}
+                           {:chain-id "4" :total-amount (money/bignumber "0") :type :disabled}]
+          expected        [{:chain-id "1" :total-amount (money/bignumber "0") :type :default}
+                           {:chain-id "2" :total-amount (money/bignumber "200") :type :default}
+                           {:chain-id "3" :total-amount (money/bignumber "0") :type :default}
+                           {:chain-id "4" :total-amount (money/bignumber "0") :type :disabled}]]
+      (is (map/deep-compare-maps expected (utils/clean-network-amounts network-amounts))))))
+
+(deftest test-loading-network-amounts
+  (testing "Assigns :loading type to affordable networks except for disabled ones"
+    (let [valid-networks     ["1" "2" "3"]
+          disabled-chain-ids ["3"]
+          receiver-networks  ["1" "2"]
+          to?                true
+          expected           [{:chain-id "1" :type :loading}
+                              {:chain-id "2" :type :loading}
+                              {:type :add}]]
+      (is
+       (map/deep-compare-maps
+        expected
+        (utils/loading-network-amounts valid-networks disabled-chain-ids receiver-networks to?)))))
+
+  (testing "Assigns :disabled type with zero total-amount to disabled networks when to? is false"
+    (let [valid-networks     ["1" "2" "3"]
+          disabled-chain-ids ["2" "3"]
+          receiver-networks  ["1"]
+          to?                false
+          expected           [{:chain-id "1" :type :loading}
+                              {:chain-id "2" :type :disabled :total-amount (money/bignumber "0")}
+                              {:chain-id "3" :type :disabled :total-amount (money/bignumber "0")}]]
+      (is
+       (map/deep-compare-maps
+        expected
+        (utils/loading-network-amounts valid-networks disabled-chain-ids receiver-networks to?)))))
+
+  (testing "Filters out networks not in receiver networks when to? is true"
+    (let [valid-networks     ["1" "2" "3" "4"]
+          disabled-chain-ids ["2"]
+          receiver-networks  ["1" "3"]
+          to?                true
+          expected           [{:chain-id "1" :type :loading}
+                              {:chain-id "3" :type :loading}]]
+      (is
+       (map/deep-compare-maps
+        expected
+        (utils/loading-network-amounts valid-networks disabled-chain-ids receiver-networks to?)))))
+
+  (testing "Appends :add type if receiver network count is less than available networks and to? is true"
+    (let [valid-networks     ["1" "2" "3"]
+          disabled-chain-ids ["2"]
+          receiver-networks  ["1"]
+          to?                true
+          expected           [{:chain-id "1" :type :loading}
+                              {:type :add}]]
+      (is
+       (map/deep-compare-maps
+        expected
+        (utils/loading-network-amounts valid-networks disabled-chain-ids receiver-networks to?))))))
diff --git a/src/utils/map.cljs b/src/utils/map.cljs
@@ -0,0 +1,15 @@
+(ns utils.map
+  (:require [utils.money :as money]))
+
+(defn deep-compare-maps
+  "Recursively compare two maps, using money/equal-to for bignumber values."
+  [map1 map2]
+  (and (= (set (keys map1)) (set (keys map2)))
+       (every? (fn [k]
+                 (let [v1 (get map1 k)
+                       v2 (get map2 k)]
+                   (cond
+                     (and (money/bignumber? v1) (money/bignumber? v2)) (money/equal-to v1 v2)
+                     (map? v1)                                         (deep-compare-maps v1 v2)
+                     :else                                             (= v1 v2))))
+               (keys map1))))
diff --git a/src/utils/money.cljs b/src/utils/money.cljs
@@ -37,6 +37,11 @@
       (new BigNumber (normalize (str n)))
       (catch :default _ nil))))
 
+(defn bignumber?
+  "Check if the value is a bignumber."
+  [x]
+  (instance? BigNumber x))
+
 (defn greater-than-or-equals
   [^js bn1 ^js bn2]
   (.greaterThanOrEqualTo bn1 bn2))