Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong public key is shown on keycard login screen #10272

Closed
churik opened this issue Apr 3, 2020 · 6 comments · Fixed by #10321
Closed

Wrong public key is shown on keycard login screen #10272

churik opened this issue Apr 3, 2020 · 6 comments · Fixed by #10321
Projects

Comments

@churik
Copy link
Member

churik commented Apr 3, 2020

Bug Report

Problem

Value of public key on login screen is not corresponding real public key of keycard user.

Expected behavior

no public key is shown or right value of public key

Actual behavior

Genymotion for personal use - Google Pixel9 (1080x1920, 420dpi) - 192 168 57 103 2020-04-03 15-58-05

Reproduction

  • Open Status
  • Create account with keycard
  • Log out
  • Navigate to login screen

Additional Information

  • Status version: nightly 03/04/2020
  • Operating System: Android
@churik churik added bug labels Apr 3, 2020
@churik
Copy link
Member Author

churik commented Apr 3, 2020

cc @guylouis

@guylouis guylouis added this to HIGH in Keycard Apr 6, 2020
@rasom rasom self-assigned this Apr 9, 2020
@rasom
Copy link
Member

rasom commented Apr 9, 2020

@churik @guylouis that's actually key-did, not public-key. Should I change it?

@rasom
Copy link
Member

rasom commented Apr 9, 2020

We do not show it for a regular multiacc at all.

@guylouis
Copy link
Contributor

guylouis commented Apr 9, 2020

I would make it consistent between regular multiaccount and keycard multiaccount, and not show it at all
@hesterbruikman agreed ?

@churik
Copy link
Member Author

churik commented Apr 10, 2020

No objections from my side

@hesterbruikman
Copy link
Contributor

Agree to removing it.

Following designs the key should actually be shown for regular multiaccount as well. I'll update Figma to reflect that we do not show a key on the sign in screen. We've had issues there around what key actually should be shown, which will become more confusing when we add multiple chat keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Keycard
CLOSED
Development

Successfully merging a pull request may close this issue.

4 participants