Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Human Readable data display when signing using eth_signTypedData_v3 #12535

Closed
D4nte opened this issue Sep 2, 2021 · 5 comments · Fixed by #12986
Closed

Human Readable data display when signing using eth_signTypedData_v3 #12535

D4nte opened this issue Sep 2, 2021 · 5 comments · Fixed by #12986
Assignees
@flexsurfer
Labels
feature feature requests

Comments

@D4nte
Copy link

D4nte commented Sep 2, 2021

For the Status Community Curation dApp, poll responses and votes are signed using EIP-712: Ethereum typed structured data hashing and signing.

Currently, the data is displayed in one line JSON format.

Instead, we should display the data in a more human readable format.

The EIP-712 provides examples such as:

image

https://status-im.github.io/js-waku/eth-pm/ can be used to play around (broadcast encryption public key step).
@D4nte D4nte added the feature feature requests label Sep 2, 2021
@D4nte D4nte mentioned this issue Sep 2, 2021
Closed
flexsurfer added a commit that referenced this issue Jan 10, 2022
@flexsurfer
[#12535] Human Readable data display when signing using eth_signTyped…
d1f6a22 
…Data_v3
@flexsurfer flexsurfer mentioned this issue Jan 10, 2022
Merged
flexsurfer added a commit that referenced this issue Jan 11, 2022
@flexsurfer
[#12535] Human Readable data display when signing using eth_signTyped…
c466f96 
…Data_v3

Signed-off-by: andrey <motor4ik@gmail.com>
qfrank pushed a commit to qfrank/status-react that referenced this issue Jan 28, 2022
@flexsurfer @qfrank
[status-im#12535] Human Readable data display when signing using eth_…
20dcc87 
…signTypedData_v3

Signed-off-by: andrey <motor4ik@gmail.com>
@D4nte
Copy link
Author

D4nte commented Feb 21, 2022

In which version is this released? I tried 1.18.2 and it's still a one liner.

@D4nte
Copy link
Author

D4nte commented Feb 21, 2022 •
edited

Screenshot_20220221-163755.jpg

Cc @qfrank @flexsurfer

@flexsurfer
Copy link
Member

@D4nte is this keycard ?

@flexsurfer flexsurfer reopened this Feb 21, 2022
@flexsurfer flexsurfer self-assigned this Feb 21, 2022
@D4nte
Copy link
Author

D4nte commented Feb 21, 2022

@D4nte is this keycard ?

Yes

@churik
Copy link
Member

churik commented Feb 23, 2022

@D4nte
still not into release, should be in 1.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flexsurfer flexsurfer

Labels
feature feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12535] Human Readable data display when signing using eth_signTyped… status-im/status-mobile
3 participants
@D4nte @churik @flexsurfer