Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Request issues #15679

Closed
2 tasks
ilmotta opened this issue Apr 18, 2023 · 0 comments · Fixed by #15685
Closed
2 tasks

Contact Request issues #15679

ilmotta opened this issue Apr 18, 2023 · 0 comments · Fixed by #15685
Assignees
@ilmotta
Labels
E:Mobile Bug MVP

Comments

@ilmotta
Copy link
Contributor

ilmotta commented Apr 18, 2023

Problem

Contact Request flows are incredibly difficult to get right, so more fixes are on the way in status-go from PR status-im/status-go#3379.

Resolving this issue means to:

  • Make sure status-mobile works well with the upcoming status-go changes.
  • Stop using wakuext_addContact, prefer wakuext_sendContactRequest.
@ilmotta ilmotta self-assigned this Apr 18, 2023
@ilmotta ilmotta mentioned this issue Apr 18, 2023
Merged
2 tasks
ilmotta added a commit that referenced this issue Apr 25, 2023
@ilmotta
Various fixes for Contact Request flows (2nd attempt) (#15685)
30f0b43 
- Make sure status-mobile works well with the upcoming status-go changes in PR
  status-im/status-go#3379.
- Replace calls to `wakuext_addContact` with `wakuext_sendContactRequest`. This
  is what's been aligned with the desktop team, as we will go on to remove
  `wakuext_addContact` in the near future.

Fixes #15679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilmotta ilmotta

Labels
E:Mobile Bug MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various fixes for Contact Request flows (2nd attempt) status-im/status-mobile
1 participant
@ilmotta