Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread counter is shown instead of unread badge for regular messages in a group chat and chat tab #16481

Closed
VolodLytvynenko opened this issue Jul 4, 2023 · 0 comments · Fixed by #16610
Closed

Unread counter is shown instead of unread badge for regular messages in a group chat and chat tab #16481

VolodLytvynenko opened this issue Jul 4, 2023 · 0 comments · Fixed by #16610
Assignees
@ulisesmac
Labels
E:Mobile Bug MVP group-chat

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Jul 4, 2023 •
edited

Steps to reproduce:

  1. Be a member of a group chat.
  2. Send a non-mention message to the group chat.
  3. Check the display of the unread indicator.

Actual result:

The unread counter is shown instead of an unread badge for non-mention messages in the group chat and chat tab
image
image

Expected result:

  • An unread badge should be displayed instead of the unread counter for regular (non-mention and non-reply) messages in the group chat

  • An unread badge should be displayed instead of the unread counter for regular (non-mention and non-reply) messages in the chat tab

image

https://www.figma.com/file/7KIYbhoqNGAIFonE0w9TDz/Messages-for-Mobile?type=design&node-id=1424-342207&mode=design&t=gmnAl5Vb0rMg8CJ9-0
@ulisesmac ulisesmac self-assigned this Jul 12, 2023
@ulisesmac ulisesmac mentioned this issue Jul 14, 2023
Merged
@VolodLytvynenko VolodLytvynenko changed the title Unread counter is shown instead of unread badge for non-mention messages in a group chat Unread counter is shown instead of unread badge for non-mention messages in a group chat and chat tab Jul 17, 2023
@VolodLytvynenko VolodLytvynenko changed the title Unread counter is shown instead of unread badge for non-mention messages in a group chat and chat tab Unread counter is shown instead of unread badge for regular messages in a group chat and chat tab Jul 17, 2023
ulisesmac added a commit that referenced this issue Jul 28, 2023
@ulisesmac
[#16481] Fix unread badge in group chats (#16610)
82645f5 
* Small refactor & add customization color to `info-count` component
* Fix notification mark in group chats for no mentions, also notification alignment styles in the component
* Code style: `change > 0` for `pos?`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
E:Mobile Bug MVP group-chat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#16481] Fix unread badge group chats status-im/status-mobile
3 participants
@cammellos @VolodLytvynenko @ulisesmac