Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community invite is not received if it was shared by non-admin #17116

Closed
churik opened this issue Aug 25, 2023 · 12 comments · Fixed by #18131
Closed

Community invite is not received if it was shared by non-admin #17116

churik opened this issue Aug 25, 2023 · 12 comments · Fixed by #18131

Comments

@churik
Copy link
Member

churik commented Aug 25, 2023

Bug Report

Problem

Community invite is not received if the user shares the community of which they are not admin.

Expected behavior

Can see the community invite

Actual behavior

The unread badge is shown, but there is no invite to community in 1-1 chat

Reproduction

Prerequisites:

  • User1, User2 and User3 are contacts
  • User1 creates any community and shares it with User2

Steps:

  1. User2: community > options > Share community to User3
  2. User3: see unread indicator > open chat with User2

Additional Information

  • Status version: nightly 25/08/23
  • Operating System: Android, iOS
FILE.2023-08-25.17.45.55.mp4
@ibrkhalil
Copy link
Contributor

I reproduced this issue once where all devices/emulators had different versions (Some old and some new), But on latest, I can't produce.
Can you please check on the latest build on all devices/emulators?

@churik
Copy link
Member Author

churik commented Aug 28, 2023

It was reproduced for me on nightly 25/08/23.

What version do you mean?

@churik
Copy link
Member Author

churik commented Aug 28, 2023

It is reproduced on PR builds #17091, which contain latest version of status-go.

@ibrkhalil
Copy link
Contributor

ibrkhalil commented Aug 28, 2023

if you are sure that User 2 is on the latest version.
Okay, Will investigate more

@ibrkhalil
Copy link
Contributor

Hey @churik, I couldn't reproduce it on the latest version.

@pavloburykh
Copy link
Contributor

pavloburykh commented Sep 25, 2023

Hey @churik, I couldn't reproduce it on the latest version.

Hi @ibrkhalil! The issue is still still reproducible.

I have updated prerequisites. Non admin User 2 who shares the community should be a community member. Try the following steps.

Expected behavior

Can see the community invite

Actual behavior

The unread badge is shown, but there is no invite to community in 1-1 chat

Reproduction

Prerequisites:

  • User1, User2 and User3 are contacts
  • User1 creates any community and shares it with User2
  • User 2 joins the community

Steps:

  1. User2: community > options > Share community to User3
  2. User3: see unread indicator > open chat with User2

@ibrkhalil ibrkhalil removed their assignment Sep 26, 2023
@ibrkhalil
Copy link
Contributor

Unassigning as I couldn't do much with this task.

@ilmotta
Copy link
Contributor

ilmotta commented Nov 20, 2023

@pavloburykh, I just followed the exact steps to reproduce this issue, but it all works for me on status-mobile develop (commit 86c5505). Once you find the time, could you try to reproduce the bug again? Just because your last comment is from ~3 months ago, and many changes were merged into status-go, so maybe this issue can be closed already.

@ibrkhalil, were you able to reproduce the bug? If so, have you done anything different from the reproduction steps shared by @pavloburykh here #17116 (comment)?

@ibrkhalil
Copy link
Contributor

@pavloburykh, I just followed the exact steps to reproduce this issue, but it all works for me on status-mobile develop (commit 86c5505). Once you find the time, could you try to reproduce the bug again? Just because your last comment is from ~3 months ago, and many changes were merged into status-go, so maybe this issue can be closed already.

@ibrkhalil, were you able to reproduce the bug? If so, have you done anything different from the reproduction steps shared by @pavloburykh here #17116 (comment)?

Yup, I reproduced it
Reproducing it is flaky

@pavloburykh
Copy link
Contributor

Once you find the time, could you try to reproduce the bug again?

Hey @ilmotta! I am still reproducing the issue. I have tried in release and latest nightly builds. Below is the video recorded on release builds.

In my case reproducing is not falky, easily reproducing the issue on every try using steps from this comment #17116 (comment)

@ilmotta is community created on Desktop?

comm_not_shared.mp4

@ibrkhalil
Copy link
Contributor

Once you find the time, could you try to reproduce the bug again?

Hey @ilmotta! I am still reproducing the issue. I have tried in release and latest nightly builds. Below is the video recorded on release builds.

In my case reproducing is not falky, easily reproducing the issue on every try using steps from this comment #17116 (comment)

@ilmotta is community created on Desktop?

comm_not_shared.mp4

I am sorry, I thought this was the admin offline one 🤦‍♂️
But yeah, I am going to fix this one too

@ilmotta
Copy link
Contributor

ilmotta commented Nov 21, 2023

is community created on Desktop?

Yes @pavloburykh, same steps you outlined. I never create communities on mobile. But since @ibrkhalil mentioned flakiness, I was probably just lucky and thought the issue was already fixed.

Since the last comment you guys shared here were at the end of September and I was lucky to not hit the bug, I thought we could close the issue. Thanks for re-testing @pavloburykh.

But yeah, I am going to fix this one too

Cool @ibrkhalil, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment