Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect account info on collectible info page to backend #17938

Closed
vkjr opened this issue Nov 17, 2023 · 0 comments · Fixed by #18277
Closed

Connect account info on collectible info page to backend #17938

vkjr opened this issue Nov 17, 2023 · 0 comments · Fixed by #18277
Assignees
@ulisesmac
Labels
E:Mobile Bug MVP E:Mobile Wallet Collectibles Page MVP all issues for the collectibles page of the wallet E:Mobile Wallet MVP Design system components, initial research and page wireframes

Comments

@vkjr
Copy link
Contributor

vkjr commented Nov 17, 2023

Problem

On collectible info page account info isn't connected to backend

Note:

When collectibles are fetched for a bunch of addresses, backend doesn't add ownership address to collectible info, so cooperation with a backend needed. Or we can fetch collectibles for every address separately and add info about current address on mobile side

Screenshot 2023-11-17 at 20 43 03 behavior
@vkjr vkjr added E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Collectibles Page MVP all issues for the collectibles page of the wallet labels Nov 17, 2023
@vkjr vkjr mentioned this issue Nov 17, 2023
Merged
@vkjr vkjr self-assigned this Nov 20, 2023
@ulisesmac ulisesmac assigned ulisesmac and unassigned vkjr Dec 6, 2023
@ulisesmac ulisesmac mentioned this issue Dec 22, 2023
Merged
ulisesmac added a commit that referenced this issue Jan 4, 2024
@ulisesmac
[#17938] Collectibles per account (#18277)
4ff5e4d 
* Update wallet events and subs to handle collectibles per account

Additionally,
 - Move collectibles related events to a new events namespace (`status-im.contexts.wallet.events.collectibles`).
 - Update tests to consider collectibles per account.

* Update collectibles tab to handle a current viewing account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
E:Mobile Bug MVP E:Mobile Wallet Collectibles Page MVP all issues for the collectibles page of the wallet E:Mobile Wallet MVP Design system components, initial research and page wireframes
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#17938] Collectibles per account status-im/status-mobile
2 participants
@vkjr @ulisesmac