Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet - Implement remove account confirmation UI for generated account and watched address #18421

Closed
Tracked by #18575
smohamedjavid opened this issue Jan 6, 2024 · 1 comment · Fixed by #18518
Closed
Tracked by #18575

Wallet - Implement remove account confirmation UI for generated account and watched address #18421

smohamedjavid opened this issue Jan 6, 2024 · 1 comment · Fixed by #18518
Assignees
@Rende11
Labels
E:Mobile Wallet Accounts Page MVP all issues for the accounts page of the wallet E:Mobile Wallet Feature - Delete Account All features related to the delete account feature feature feature requests

Comments

@smohamedjavid
Copy link
Member

Feature Issue

Implement remove account confirmation UI for

  • Generated account
  • Watched address

Designs

Figma Link

Description

The remove account confirmation will be shown to the user

  • when the user taps on the trash icon (in the top right corner) in the account edit screen
  • on tap of Remove account action in the account options bottom sheet

Acceptance Criteria

  • The confirmation UI is shown on both entry points

Notes

  • The integration with status-go will be handled in a separate issue
  • The Recovery phase flow in the design would be for the generated account flow
  • The Private key flow is not covered in this issue as we need to implement the keypair flows.
@smohamedjavid smohamedjavid added feature feature requests E:Mobile Wallet Accounts Page MVP all issues for the accounts page of the wallet labels Jan 6, 2024
@smohamedjavid smohamedjavid mentioned this issue Jan 6, 2024
Closed
@Rende11
Copy link
Collaborator

Rende11 commented Jan 8, 2024

I would like to implement it

Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 15, 2024
@Rende11
Remove account confirmation UI status-im#18421
6102c31
Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 15, 2024
@Rende11
Remove account confirmation UI status-im#18421
8f12c71
@Rende11 Rende11 mentioned this issue Jan 16, 2024
Merged
Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 17, 2024
@Rende11
Remove account confirmation UI status-im#18421
1442d1a
Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 18, 2024
@Rende11
Remove account confirmation UI status-im#18421
ddb552b
@J-Son89 J-Son89 mentioned this issue Jan 19, 2024
Closed
4 tasks
@J-Son89 J-Son89 added the E:Mobile Wallet Feature - Delete Account All features related to the delete account feature label Jan 19, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 19, 2024
@Rende11
Remove account confirmation UI status-im#18421
596a22f
Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 19, 2024
@Rende11
Remove account confirmation UI status-im#18421
63c0154 
Remove account confirmation UI status-im#18421

Fix alignment

Fix context-tag-subtitle
Rende11 added a commit to Rende11/status-mobile that referenced this issue Jan 22, 2024
@Rende11
Remove account confirmation UI status-im#18421
4280b55 
Remove account confirmation UI status-im#18421

Fix alignment

Fix context-tag-subtitle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rende11 Rende11

Labels
E:Mobile Wallet Accounts Page MVP all issues for the accounts page of the wallet E:Mobile Wallet Feature - Delete Account All features related to the delete account feature feature feature requests
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#18421] Wallet - remove account confirmation Rende11/status-mobile
3 participants
@Rende11 @smohamedjavid @J-Son89