Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send flow: Asset need to be selected twice #18495

Closed
OmarBasem opened this issue Jan 15, 2024 · 1 comment · Fixed by #18532
Closed

Send flow: Asset need to be selected twice #18495

OmarBasem opened this issue Jan 15, 2024 · 1 comment · Fixed by #18532
Assignees
@ulisesmac
Labels
E:Mobile Bug MVP E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet E:Mobile Wallet Send Page MVP all issues for the send page of the wallet high-priority

Comments

@OmarBasem
Copy link
Member

When going back from send_input screen to select_asset screen to choose a different asset, the selected asset does not update.

The user needs to go back again and select the asset again (twice)
@OmarBasem OmarBasem added E:Mobile Bug MVP E:Mobile Wallet Send Page MVP all issues for the send page of the wallet E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet labels Jan 15, 2024
@ulisesmac ulisesmac self-assigned this Jan 16, 2024
@ulisesmac
Copy link
Contributor

I've just noticed there's a subscription being called only on component mount:

(rf/sub [:wallet/wallet-send-token]) inside the ns status-im.contexts.wallet.send.input-amount.view.

It has given some problems before, such as the well know "doesn't support name:", addressed some weeks ago by @briansztamfater.

The PR:
#18326 (comment)

We need to solve this problem by properly calling the sub.
It also lacks of an effect to clean the db when navigating back.

I'm taking this issue

This was referenced Jan 16, 2024
Merged
Merged
ulisesmac added a commit that referenced this issue Feb 1, 2024
@ulisesmac
[#18495] Fix token not ready for next screen (#18532)
b6ddd8b 
* Fix exception thrown re-frame don't have the subs' value ready

* Make Token malli schema more lenient

*  Make `get-standard-crypto-format` able to work with `nil` values

*  Refactor token screen to move subscriptions inside render function

* Make token input reactive to on-swap

* Remove `crypto-currency?` atom to properly react to state changes

* Fix component tests
ulisesmac added a commit that referenced this issue Feb 2, 2024
@ulisesmac
[#18495] Fix token not ready for next screen (#18532)
c53e608 
* Fix exception thrown re-frame don't have the subs' value ready

* Make Token malli schema more lenient

*  Make `get-standard-crypto-format` able to work with `nil` values

*  Refactor token screen to move subscriptions inside render function

* Make token input reactive to on-swap

* Remove `crypto-currency?` atom to properly react to state changes

* Fix component tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
E:Mobile Bug MVP E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet E:Mobile Wallet Send Page MVP all issues for the send page of the wallet high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#18495] Fix token not ready for next screen status-im/status-mobile
2 participants
@OmarBasem @ulisesmac