Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account selection: watch-only accounts are displayed in the account selector #18752

Closed
qoqobolo opened this issue Feb 7, 2024 · 0 comments · Fixed by #18809
Closed

Account selection: watch-only accounts are displayed in the account selector #18752

qoqobolo opened this issue Feb 7, 2024 · 0 comments · Fixed by #18809
Assignees
@mohsen-ghafouri
Labels
E:Mobile Bug MVP E:Mobile [Crew] Account Selection MVP https://www.notion.so/Ledger-Drops-b0df9c843f904bb380133375bae3faa7 E:Mobile Release 2.27 Release Blocker
Milestone
2.27.0 Alpha

Comments

@qoqobolo
Copy link
Contributor

qoqobolo commented Feb 7, 2024

Bug Report

Problem

We should not include watch-only addresses in account selection when joining a community (both for sharing with the community and airdrop?)

video_2024-02-07_18-34-40.mp4

Reproduction

  1. Add a watch-only address
  2. Open a token-gated community > open account selection screen

Expected behavior

The W/O address is not in the list

Actual behavior

The W/O address is displayed in the list

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@qoqobolo qoqobolo added this to the 2.27.0 Alpha milestone Feb 7, 2024
@ilmotta ilmotta self-assigned this Feb 8, 2024
mohsen-ghafouri added a commit that referenced this issue Feb 13, 2024
@mohsen-ghafouri
[#18752] fix: The W/O address shouldn't be in account selection
a8a279a
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Feb 13, 2024
Merged
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: scroll-enabled? renamed in bottom-sheet
3fece91
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: eliminate W/O address from account selection
4158704
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: resolve join token gated without permission
45b9e98
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: The W/O address shouldn't be in account selection
f98f009
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: eliminate W/O address from account selection
aff70ff
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: resolve join token gated without permission
9e3924e
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: unit test issue
a28aaa7
mohsen-ghafouri added a commit that referenced this issue Feb 14, 2024
@mohsen-ghafouri
[#18752] fix: The W/O address shouldn't be in account selection (#18809)
1d2c01c
mohsen-ghafouri added a commit that referenced this issue Feb 15, 2024
@mohsen-ghafouri
[#18752] fix: scroll-enabled? renamed in bottom-sheet
c8470a6
ilmotta pushed a commit that referenced this issue Feb 15, 2024
@mohsen-ghafouri @ilmotta
[#18752] fix: The W/O address shouldn't be in account selection (#18809)
81e8c7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
E:Mobile Bug MVP E:Mobile [Crew] Account Selection MVP https://www.notion.so/Ledger-Drops-b0df9c843f904bb380133375bae3faa7 E:Mobile Release 2.27 Release Blocker
Projects
None yet
Milestone
2.27.0 Alpha
Development

Successfully merging a pull request may close this issue.

[#18752] fix: The W/O address shouldn't be in account selection status-im/status-mobile
4 participants
@ilmotta @qoqobolo @mohsen-ghafouri @pavloburykh