Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal scanner is not triggered via eth address share screen #18934

Closed
VolodLytvynenko opened this issue Feb 21, 2024 · 2 comments · Fixed by #19409
Closed

Universal scanner is not triggered via eth address share screen #18934

VolodLytvynenko opened this issue Feb 21, 2024 · 2 comments · Fixed by #19409
Assignees

Comments

@VolodLytvynenko
Copy link
Contributor

Follow up for #18928

Steps:

  1. Open wallet -> open any eth account -> tap 'receive'
  2. Tap 'scan' button

Actual result:

The universal scanner is not triggered

scanner.mp4

Expected result:

The universal scanner is triggered

@VolodLytvynenko VolodLytvynenko changed the title Univeral scanner is not triggered via wallet Universal scanner is not triggered via eth address share screen Feb 21, 2024
@J-Son89
Copy link
Member

J-Son89 commented Feb 21, 2024

align with @alwx when implementing this! -> this is the same as the universal scanner but with a subset of the features (afaik) -
best to align with design too.
i.e what happens if you use this scanner but scan something non related to the wallet (e.g community channel qr)

@VolodLytvynenko
Copy link
Contributor Author

align with @alwx when implementing this! -> this is the same as the universal scanner but with a subset of the features (afaik) - best to align with design too. i.e what happens if you use this scanner but scan something non related to the wallet (e.g community channel qr)

Just aligned this with a design team. The universal scanner should be triggered https://discord.com/channels/624634427930312714/852533718790570015/1209862462481109034

@ulisesmac ulisesmac self-assigned this Mar 21, 2024
ulisesmac added a commit that referenced this issue Mar 27, 2024
* Fix linear-gradient breaking when `customization-color` is unknown

* Fix exception when scanning an address due to non-existing navigation route

* Dispatches universal QR code scanner on share address modal
cammellos pushed a commit that referenced this issue Mar 27, 2024
* Fix linear-gradient breaking when `customization-color` is unknown

* Fix exception when scanning an address due to non-existing navigation route

* Dispatches universal QR code scanner on share address modal
mmilad75 pushed a commit that referenced this issue Apr 2, 2024
* Fix linear-gradient breaking when `customization-color` is unknown

* Fix exception when scanning an address due to non-existing navigation route

* Dispatches universal QR code scanner on share address modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants